Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full-picture with space in filename does not render #115

Open
gangelop opened this issue Sep 8, 2020 · 3 comments
Open

full-picture with space in filename does not render #115

gangelop opened this issue Sep 8, 2020 · 3 comments

Comments

@gangelop
Copy link
Contributor

gangelop commented Sep 8, 2020

full-picture with space in filename does not render
In a gallery settings.yaml, the image with filename test pic.jpg does not render in the browser. There's just a gray background.

sections:
    - type: full-picture
      image: test pic.jpg

It works if the space is removed (and the underlying file appropriately renamed).

sections:
    - type: full-picture
      image: test-pic.jpg

I'm a bit at a loss with this one. No idea what's causing it.

@gangelop
Copy link
Contributor Author

gangelop commented Sep 8, 2020

After working on #116 I see there are multiple areas in the code with such issues. In general it is assumed that paths, not just filenames, won't contain whitespaces, which is a silly assumption and needs fixing.

@halloleo
Copy link

I noticed the same: Prosopopee doesn't lay well with spaces in file names.

@crypto512
Copy link
Contributor

I've a similar issue when building where directory name contain space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants