From 2ed524b140295b7ffecbb15b0352d473faaa12b4 Mon Sep 17 00:00:00 2001 From: saurabh-narkhede Date: Tue, 19 Mar 2024 19:35:57 +0530 Subject: [PATCH 1/2] UOE-10275: Changes for `bidid`, `origbidid` and `piid` in logger ane tracker --- analytics/pubmatic/logger.go | 5 +- analytics/pubmatic/logger_test.go | 249 +++++++++++------- analytics/pubmatic/record.go | 1 + modules/pubmatic/openwrap/tracker/create.go | 6 +- .../pubmatic/openwrap/tracker/create_test.go | 42 +-- .../pubmatic/openwrap/tracker/tracker_test.go | 4 +- 6 files changed, 185 insertions(+), 122 deletions(-) diff --git a/analytics/pubmatic/logger.go b/analytics/pubmatic/logger.go index c214c4ab73b..bc96021117d 100644 --- a/analytics/pubmatic/logger.go +++ b/analytics/pubmatic/logger.go @@ -386,8 +386,8 @@ func getPartnerRecordsByImp(ao analytics.AuctionObject, rCtx *models.RequestCtx) Latency1: rCtx.BidderResponseTimeMillis[seat], // it is set inside auctionresponsehook for all bidders KGPV: kgpv, KGPSV: kgpsv, - BidID: utils.GetOriginalBidId(bid.ID), - OrigBidID: utils.GetOriginalBidId(bid.ID), + BidID: bid.ImpID, + OrigBidID: bid.ImpID, DefaultBidStatus: 0, // this will be always 0 , decide whether to drop this field in future ServerSide: 1, MatchedImpression: rCtx.MatchedImpression[seat], @@ -400,6 +400,7 @@ func getPartnerRecordsByImp(ao analytics.AuctionObject, rCtx *models.RequestCtx) GrossECPM: tracker.Tracker.PartnerInfo.GrossECPM, PartnerSize: tracker.Tracker.PartnerInfo.AdSize, ADomain: tracker.Tracker.PartnerInfo.Advertiser, + Piid: utils.GetOriginalBidId(bid.ID), } if pr.NetECPM == 0 { diff --git a/analytics/pubmatic/logger_test.go b/analytics/pubmatic/logger_test.go index 8c83c386728..17631d0ea33 100644 --- a/analytics/pubmatic/logger_test.go +++ b/analytics/pubmatic/logger_test.go @@ -257,12 +257,13 @@ func TestGetPartnerRecordsByImp(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", Adformat: models.Video, + Piid: "bid-id-1", }, }, }, @@ -308,14 +309,15 @@ func TestGetPartnerRecordsByImp(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", Adformat: models.Native, NetECPM: 10, GrossECPM: 10, + Piid: "bid-id-1", }, }, }, @@ -364,8 +366,8 @@ func TestGetPartnerRecordsByImp(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", @@ -373,6 +375,7 @@ func TestGetPartnerRecordsByImp(t *testing.T) { NetECPM: 10, GrossECPM: 10, Latency1: 20, + Piid: "bid-id-1", }, }, }, @@ -419,14 +422,15 @@ func TestGetPartnerRecordsByImp(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", NetECPM: 10, GrossECPM: 10, MatchedImpression: 1, + Piid: "bid-id-1", }, }, }, @@ -473,13 +477,14 @@ func TestGetPartnerRecordsByImp(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "30x50", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", NetECPM: 10, GrossECPM: 10, + Piid: "bid-id-1", }, }, }, @@ -526,13 +531,14 @@ func TestGetPartnerRecordsByImp(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "30x50v", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", NetECPM: 10, GrossECPM: 10, + Piid: "bid-id-1", }, }, }, @@ -577,14 +583,15 @@ func TestGetPartnerRecordsByImp(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "pubdeal", DealChannel: "PMP", ServerSide: 1, OriginalCur: "USD", NetECPM: 10, GrossECPM: 10, + Piid: "bid-id-1", }, }, }, @@ -635,11 +642,12 @@ func TestGetPartnerRecordsByImp(t *testing.T) { BidderCode: "appnexus", PartnerSize: "0x0", BidID: "prebid-bid-id-1", - OrigBidID: "bid-id-1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, ADomain: "google.com", + Piid: "bid-id-1", }, }, }, @@ -720,8 +728,8 @@ func TestGetPartnerRecordsByImpForTracker(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "15x15", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", @@ -733,6 +741,7 @@ func TestGetPartnerRecordsByImpForTracker(t *testing.T) { ADomain: "sony.com", KGPV: "kgpv", KGPSV: "kgpsv", + Piid: "bid-id-1", }, }, }, @@ -797,8 +806,8 @@ func TestGetPartnerRecordsByImpForTracker(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "15x15", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", @@ -810,6 +819,7 @@ func TestGetPartnerRecordsByImpForTracker(t *testing.T) { ADomain: "sony.com", KGPV: "kgpv", KGPSV: "kgpv", + Piid: "bid-id-1", }, }, }, @@ -875,21 +885,23 @@ func TestGetPartnerRecordsByImpForDroppedBids(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", + Piid: "bid-id-1", }, { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-2", - OrigBidID: "bid-id-2", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", + Piid: "bid-id-2", }, }, }, @@ -943,21 +955,23 @@ func TestGetPartnerRecordsByImpForDroppedBids(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", + Piid: "bid-id-1", }, { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-2", - OrigBidID: "bid-id-2", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", + Piid: "bid-id-2", }, }, }, @@ -1023,13 +1037,14 @@ func TestGetPartnerRecordsByImpForDefaultBids(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", NetECPM: 10, GrossECPM: 10, + Piid: "bid-id-1", }, }, }, @@ -1092,19 +1107,20 @@ func TestGetPartnerRecordsByImpForDefaultBids(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-2", - OrigBidID: "bid-id-2", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-2", }, { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", @@ -1112,6 +1128,7 @@ func TestGetPartnerRecordsByImpForDefaultBids(t *testing.T) { GrossECPM: 0, Nbr: exchange.ErrorTimeout.Ptr(), PostTimeoutBidStatus: 1, + Piid: "bid-id-1", }, }, }, @@ -1174,14 +1191,15 @@ func TestGetPartnerRecordsByImpForDefaultBids(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: "USD", NetECPM: 0, GrossECPM: 0, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1401,8 +1419,8 @@ func TestGetPartnerRecordsByImpForSeatNonBid(t *testing.T) { PartnerSize: "10x50", GrossECPM: 10, NetECPM: 10, - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCPM: 0, @@ -1410,6 +1428,7 @@ func TestGetPartnerRecordsByImpForSeatNonBid(t *testing.T) { FloorValue: 10.5, FloorRuleValue: 10.5, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1483,8 +1502,8 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", GrossECPM: 10, NetECPM: 10, @@ -1494,6 +1513,7 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { FloorValue: 1, FloorRuleValue: 1, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1549,8 +1569,8 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", GrossECPM: 10, NetECPM: 10, @@ -1560,6 +1580,7 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { FloorValue: 0, FloorRuleValue: 0, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1615,8 +1636,8 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", GrossECPM: 10, NetECPM: 10, @@ -1626,6 +1647,7 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { FloorValue: 10, FloorRuleValue: 10, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1675,8 +1697,8 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", GrossECPM: 10, NetECPM: 10, @@ -1686,6 +1708,7 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { FloorValue: 10.57, FloorRuleValue: 10.57, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1738,8 +1761,8 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", GrossECPM: 10, NetECPM: 10, @@ -1749,6 +1772,7 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { FloorValue: 1000, FloorRuleValue: 1000, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1807,8 +1831,8 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", GrossECPM: 10, NetECPM: 10, @@ -1818,6 +1842,7 @@ func TestGetPartnerRecordsByImpForSeatNonBidForFloors(t *testing.T) { FloorValue: 0.12, FloorRuleValue: 0.12, Nbr: exchange.ResponseRejectedBelowFloor.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1920,13 +1945,14 @@ func TestGetPartnerRecordsByImpForPostTimeoutBidStatus(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, PostTimeoutBidStatus: 1, Nbr: exchange.ErrorTimeout.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -1996,13 +2022,14 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { BidderCode: "appnexus", PartnerSize: "0x0", BidID: "uuid", - OrigBidID: "bid-id-1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, NetECPM: 10, GrossECPM: 10, DealPriority: 1, + Piid: "bid-id-1", }, }, }, @@ -2053,14 +2080,15 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, NetECPM: 10, GrossECPM: 10, DealPriority: 0, + Piid: "bid-id-1", }, }, }, @@ -2111,8 +2139,8 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, @@ -2120,6 +2148,7 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { GrossECPM: 10, DealPriority: 1, Nbr: nbr.LossBidLostToHigherBid.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -2163,13 +2192,14 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "uuid", - OrigBidID: "uuid", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, Nbr: exchange.ErrorTimeout.Ptr(), PostTimeoutBidStatus: 1, + Piid: "uuid", }, }, }, @@ -2213,13 +2243,14 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { BidderCode: "appnexus", PartnerSize: "0x0", BidID: "uuid", - OrigBidID: "bid-id-1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, NetECPM: 10, GrossECPM: 10, OriginalCur: models.USD, Nbr: nbr.LossBidLostToDealBid.Ptr(), + Piid: "bid-id-1", }, }, }, @@ -2276,7 +2307,7 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { BidderCode: "appnexus", PartnerSize: "0x0", BidID: "uuid", - OrigBidID: "bid-id-1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, @@ -2284,6 +2315,7 @@ func TestGetPartnerRecordsByImpForBidIDCollisions(t *testing.T) { GrossECPM: 10, DealPriority: 1, WinningBidStaus: 1, + Piid: "bid-id-1", }, }, }, @@ -2352,14 +2384,15 @@ func TestGetPartnerRecordsByImpForBidExtFailure(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, NetECPM: 10, GrossECPM: 10, DealPriority: 0, + Piid: "bid-id-1", }, }, }, @@ -2410,8 +2443,8 @@ func TestGetPartnerRecordsByImpForBidExtFailure(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, @@ -2419,6 +2452,7 @@ func TestGetPartnerRecordsByImpForBidExtFailure(t *testing.T) { GrossECPM: 10, DealPriority: 0, Nbr: nil, + Piid: "bid-id-1", }, }, }, @@ -2463,13 +2497,14 @@ func TestGetPartnerRecordsByImpForBidExtFailure(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "uuid", - OrigBidID: "uuid", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, Nbr: exchange.ErrorTimeout.Ptr(), PostTimeoutBidStatus: 1, + Piid: "uuid", }, }, }, @@ -2504,14 +2539,15 @@ func TestGetPartnerRecordsByImpForBidExtFailure(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "", - OrigBidID: "", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, NetECPM: 0, GrossECPM: 0, OriginalCur: models.USD, Nbr: nbr.LossBidLostToDealBid.Ptr(), + Piid: "", }, }, }, @@ -2578,14 +2614,15 @@ func TestGetPartnerRecordsByImpForBidExtPrebidObject(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, MetaData: &MetaData{ NetworkID: 100, }, + Piid: "bid-id-1", }, }, }, @@ -2633,11 +2670,12 @@ func TestGetPartnerRecordsByImpForBidExtPrebidObject(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, + Piid: "bid-id-1", }, }, }, @@ -2685,12 +2723,13 @@ func TestGetPartnerRecordsByImpForBidExtPrebidObject(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, DealPriority: 1, + Piid: "bid-id-1", }, }, }, @@ -2738,12 +2777,13 @@ func TestGetPartnerRecordsByImpForBidExtPrebidObject(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, DealPriority: 0, + Piid: "bid-id-1", }, }, }, @@ -2792,11 +2832,12 @@ func TestGetPartnerRecordsByImpForBidExtPrebidObject(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, + Piid: "bid-id-1", }, }, }, @@ -2845,12 +2886,13 @@ func TestGetPartnerRecordsByImpForBidExtPrebidObject(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, AdDuration: ptrutil.ToPtr(10), + Piid: "bid-id-1", }, }, }, @@ -2898,10 +2940,11 @@ func TestGetPartnerRecordsByImpForBidExtPrebidObject(t *testing.T) { BidderCode: "appnexus", PartnerSize: "0x0", BidID: "prebid-bid-id-1", - OrigBidID: "bid-id-1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, + Piid: "bid-id-1", }, }, }, @@ -2968,10 +3011,11 @@ func TestGetPartnerRecordsByImpForRevShareAndBidCPM(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, + Piid: "bid-id-1", }, }, }, @@ -3031,10 +3075,11 @@ func TestGetPartnerRecordsByImpForRevShareAndBidCPM(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, + Piid: "bid-id-1", }, }, }, @@ -3085,10 +3130,11 @@ func TestGetPartnerRecordsByImpForRevShareAndBidCPM(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, + Piid: "bid-id-1", }, }, }, @@ -3140,10 +3186,11 @@ func TestGetPartnerRecordsByImpForRevShareAndBidCPM(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, + Piid: "bid-id-1", }, }, }, @@ -3205,10 +3252,11 @@ func TestGetPartnerRecordsByImpForRevShareAndBidCPM(t *testing.T) { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, + Piid: "bid-id-1", }, }, }, @@ -3291,8 +3339,8 @@ func TestGetPartnerRecordsByImpForMarketPlaceBidders(t *testing.T) { PartnerID: "appnexus", BidderCode: "appnexus", PartnerSize: "0x0", - BidID: "bid-id-1", - OrigBidID: "bid-id-1", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, @@ -3300,13 +3348,14 @@ func TestGetPartnerRecordsByImpForMarketPlaceBidders(t *testing.T) { NetECPM: 1, KGPV: "apnx_kgpv", KGPSV: "apnx_kgpv", + Piid: "bid-id-1", }, { PartnerID: "pubmatic", BidderCode: "pubmatic", PartnerSize: "0x0", - BidID: "bid-id-2", - OrigBidID: "bid-id-2", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, @@ -3314,13 +3363,14 @@ func TestGetPartnerRecordsByImpForMarketPlaceBidders(t *testing.T) { NetECPM: 2, KGPV: "pubm_kgpv", KGPSV: "pubm_kgpv", + Piid: "bid-id-2", }, { PartnerID: "pubmatic", BidderCode: "groupm", PartnerSize: "0x0", - BidID: "bid-id-3", - OrigBidID: "bid-id-3", + BidID: "imp1", + OrigBidID: "imp1", DealID: "-1", ServerSide: 1, OriginalCur: models.USD, @@ -3328,6 +3378,7 @@ func TestGetPartnerRecordsByImpForMarketPlaceBidders(t *testing.T) { NetECPM: 3, KGPV: "pubm_kgpv", KGPSV: "pubm_kgpv", + Piid: "bid-id-3", }, }, }, @@ -4385,8 +4436,8 @@ func TestSlotRecordsInGetLogAuctionObjectAsURL(t *testing.T) { }, want: want{ logger: ow.cfg.Endpoint + `?json={"pubid":5890,"pid":"0","pdvid":"0","sl":1,"s":[{"sid":"sid","sn":"imp_1_tagid_1","sz":["0x0v","100x200"],"au":"tagid_1",` + - `"ps":[{"pn":"pubmatic","bc":"pubmatic","kgpv":"","kgpsv":"","psz":"0x0","af":"","eg":0,"en":0,"l1":0,"l2":0,"t":0,"wb":0,"bidid":"bid-id-1",` + - `"origbidid":"bid-id-1","di":"-1","dc":"","db":0,"ss":1,"mi":0,"ocpm":0,"ocry":"USD"}],"rwrd":1},{"sid":"sid","sn":"imp_2_tagid_2","au":"tagid_2","ps":[]}],"dvc":{},"ft":0,"it":"sdk"}&pubid=5890`, + `"ps":[{"pn":"pubmatic","bc":"pubmatic","kgpv":"","kgpsv":"","psz":"0x0","af":"","eg":0,"en":0,"l1":0,"l2":0,"t":0,"wb":0,"bidid":"imp_1",` + + `"origbidid":"imp_1","piid":"bid-id-1","di":"-1","dc":"","db":0,"ss":1,"mi":0,"ocpm":0,"ocry":"USD"}],"rwrd":1},{"sid":"sid","sn":"imp_2_tagid_2","au":"tagid_2","ps":[]}],"dvc":{},"ft":0,"it":"sdk"}&pubid=5890`, header: http.Header{ models.USER_AGENT_HEADER: []string{""}, models.IP_HEADER: []string{""}, diff --git a/analytics/pubmatic/record.go b/analytics/pubmatic/record.go index 91bbf2731f2..1368386ede3 100644 --- a/analytics/pubmatic/record.go +++ b/analytics/pubmatic/record.go @@ -119,6 +119,7 @@ type PartnerRecord struct { WinningBidStaus int `json:"wb"` BidID string `json:"bidid"` OrigBidID string `json:"origbidid"` + Piid string `json:"piid"` DealID string `json:"di"` DealChannel string `json:"dc"` DealPriority int `json:"dp,omitempty"` diff --git a/modules/pubmatic/openwrap/tracker/create.go b/modules/pubmatic/openwrap/tracker/create.go index 7d79ecb52f9..4ab46f55c05 100644 --- a/modules/pubmatic/openwrap/tracker/create.go +++ b/modules/pubmatic/openwrap/tracker/create.go @@ -160,8 +160,8 @@ func createTrackers(rctx models.RequestCtx, trackers map[string]models.OWTracker tracker.PartnerInfo = models.Partner{ PartnerID: partnerID, BidderCode: seatBid.Seat, - BidID: utils.GetOriginalBidId(bid.ID), - OrigBidID: utils.GetOriginalBidId(bid.ID), + BidID: bid.ImpID, + OrigBidID: bid.ImpID, KGPV: kgpv, NetECPM: en, GrossECPM: eg, @@ -172,6 +172,7 @@ func createTrackers(rctx models.RequestCtx, trackers map[string]models.OWTracker FloorValue: floorValue, FloorRuleValue: floorRuleValue, DealID: "-1", + Piid: utils.GetOriginalBidId(bid.ID), } if len(bidId) > 0 { tracker.PartnerInfo.BidID = bidId @@ -274,6 +275,7 @@ func constructTrackerURL(rctx models.RequestCtx, tracker models.Tracker) string if tracker.ATTS != nil { v.Set(models.TRKATTS, strconv.Itoa(int(*tracker.ATTS))) } + v.Set(models.TRKPIID, partner.Piid) queryString := v.Encode() //Code for making tracker call http/https based on secure flag for in-app platform diff --git a/modules/pubmatic/openwrap/tracker/create_test.go b/modules/pubmatic/openwrap/tracker/create_test.go index d47edc3f349..99510521efd 100644 --- a/modules/pubmatic/openwrap/tracker/create_test.go +++ b/modules/pubmatic/openwrap/tracker/create_test.go @@ -60,7 +60,7 @@ var rctx = models.RequestCtx{ OriginalBidCPMUSD: 0, ExtBid: openrtb_ext.ExtBid{ Prebid: &openrtb_ext.ExtBidPrebid{ - BidId: "bidID-1", + BidId: "bidID-ext", Video: &openrtb_ext.ExtBidPrebidVideo{ Duration: 20, }, @@ -155,8 +155,8 @@ func Test_createTrackers(t *testing.T) { KGPV: "adunit-1@250x300", GrossECPM: 8.7, NetECPM: 8.7, - BidID: "bidID-1", - OrigBidID: "bidID-1", + BidID: "bidID-ext", + OrigBidID: "impID-1", AdSize: "250x300", AdDuration: 20, Adformat: "banner", @@ -165,6 +165,7 @@ func Test_createTrackers(t *testing.T) { FloorValue: 6.4, FloorRuleValue: 4.4, DealID: "deal-id-1", + Piid: "bidID-1", }, Platform: 5, SSAI: "mediatailor", @@ -178,7 +179,7 @@ func Test_createTrackers(t *testing.T) { CustomDimensions: "author=henry", ATTS: ptrutil.ToPtr(float64(openrtb_ext.IOSAppTrackingStatusRestricted)), }, - TrackerURL: "https:?adv=domain.com&af=banner&aps=0&atts=1&au=adunit-1&bc=pubmatic&bidid=bidID-1&cds=author%3Dhenry&di=deal-id-1&dur=20&eg=8.7&en=8.7&frv=4.4&ft=0&fv=6.4&iid=loggerIID&kgpv=adunit-1%40250x300&orig=publisher.com&origbidid=bidID-1&pdvid=1&pid=1234&plt=5&pn=prebidBidderCode&psz=250x300&pubid=5890&purl=abc.com&sl=1&slot=impID-1_adunit-1&ss=1&ssai=mediatailor&tgid=1&tst=" + strconv.FormatInt(startTime, 10), + TrackerURL: "https:?adv=domain.com&af=banner&aps=0&atts=1&au=adunit-1&bc=pubmatic&bidid=bidID-ext&cds=author%3Dhenry&di=deal-id-1&dur=20&eg=8.7&en=8.7&frv=4.4&ft=0&fv=6.4&iid=loggerIID&kgpv=adunit-1%40250x300&orig=publisher.com&origbidid=impID-1&pdvid=1&pid=1234&piid=bidID-1&plt=5&pn=prebidBidderCode&psz=250x300&pubid=5890&purl=abc.com&sl=1&slot=impID-1_adunit-1&ss=1&ssai=mediatailor&tgid=1&tst=" + strconv.FormatInt(startTime, 10), Price: 8.7, PriceModel: "CPM", PriceCurrency: "USD", @@ -234,8 +235,8 @@ func Test_createTrackers(t *testing.T) { KGPV: "adunit-1@250x300", GrossECPM: 8.7, NetECPM: 8.7, - BidID: "bidID-1", - OrigBidID: "bidID-1", + BidID: "bidID-ext", + OrigBidID: "impID-1", AdSize: "250x300", AdDuration: 20, Adformat: "banner", @@ -244,6 +245,7 @@ func Test_createTrackers(t *testing.T) { FloorValue: 6.4, FloorRuleValue: 4.4, DealID: "deal-id-1", + Piid: "bidID-1", }, Platform: 5, SSAI: "mediatailor", @@ -256,7 +258,7 @@ func Test_createTrackers(t *testing.T) { }, CustomDimensions: "author=henry", }, - TrackerURL: "https:?adv=domain.com&af=banner&aps=0&au=adunit-1&bc=pubmatic2&bidid=bidID-1&cds=author%3Dhenry&di=deal-id-1&dur=20&eg=8.7&en=8.7&frv=4.4&ft=0&fv=6.4&iid=loggerIID&kgpv=adunit-1%40250x300&orig=publisher.com&origbidid=bidID-1&pdvid=1&pid=1234&plt=5&pn=prebidBidderCode2&psz=250x300&pubid=5890&purl=abc.com&sl=1&slot=impID-1_adunit-1&ss=1&ssai=mediatailor&tgid=1&tst=" + strconv.FormatInt(startTime, 10), + TrackerURL: "https:?adv=domain.com&af=banner&aps=0&au=adunit-1&bc=pubmatic2&bidid=bidID-ext&cds=author%3Dhenry&di=deal-id-1&dur=20&eg=8.7&en=8.7&frv=4.4&ft=0&fv=6.4&iid=loggerIID&kgpv=adunit-1%40250x300&orig=publisher.com&origbidid=impID-1&pdvid=1&pid=1234&piid=bidID-1&plt=5&pn=prebidBidderCode2&psz=250x300&pubid=5890&purl=abc.com&sl=1&slot=impID-1_adunit-1&ss=1&ssai=mediatailor&tgid=1&tst=" + strconv.FormatInt(startTime, 10), Price: 8.7, PriceModel: "CPM", PriceCurrency: "USD", @@ -301,7 +303,7 @@ func TestConstructTrackerURL(t *testing.T) { }, tracker: models.Tracker{}, }, - want: "http://t.pubmatic.com/wt?adv=&af=&aps=0&au=&bc=&bidid=&di=&eg=0&en=0&ft=0&iid=&kgpv=&orig=&origbidid=&pdvid=&pid=&plt=0&pn=&psz=&pubid=0&purl=&sl=1&slot=&ss=0&tgid=0&tst=0", + want: "http://t.pubmatic.com/wt?adv=&af=&aps=0&au=&bc=&bidid=&di=&eg=0&en=0&ft=0&iid=&kgpv=&orig=&origbidid=&pdvid=&pid=&piid=&plt=0&pn=&psz=&pubid=0&purl=&sl=1&slot=&ss=0&tgid=0&tst=0", }, { name: "platform_amp_with_tracker_details", @@ -336,10 +338,11 @@ func TestConstructTrackerURL(t *testing.T) { ServerSide: 1, Advertiser: "fb.com", DealID: "420", + Piid: "1234", }, }, }, - want: "//t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&di=420&dur=10&eg=4.3&en=2.5&ft=0&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", + want: "//t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&di=420&dur=10&eg=4.3&en=2.5&ft=0&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&piid=1234&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", }, { name: "all_details_with_ssai_in_tracker", @@ -372,7 +375,7 @@ func TestConstructTrackerURL(t *testing.T) { PartnerID: "AppNexus", BidderCode: "AppNexus1", BidID: "6521", - OrigBidID: "6521", + OrigBidID: "65255", GrossECPM: 4.3, NetECPM: 2.5, KGPV: "adunit@300x250", @@ -384,10 +387,11 @@ func TestConstructTrackerURL(t *testing.T) { DealID: "420", FloorValue: 4.4, FloorRuleValue: 2, + Piid: "1234", }, }, }, - want: "https://t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&rwrd=1&sl=1&slot=1234_1234&ss=1&ssai=mediatailor&tgid=1&tst=0", + want: "https://t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=65255&pdvid=1&pid=123&piid=1234&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&rwrd=1&sl=1&slot=1234_1234&ss=1&ssai=mediatailor&tgid=1&tst=0", }, { name: "all_details_with_secure_enable_in_tracker", @@ -431,10 +435,11 @@ func TestConstructTrackerURL(t *testing.T) { DealID: "420", FloorValue: 4.4, FloorRuleValue: 2, + Piid: "1234", }, }, }, - want: "https://t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&rwrd=1&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", + want: "https://t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&piid=1234&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&rwrd=1&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", }, { name: "all_details_with_RewardInventory_in_tracker", @@ -477,10 +482,11 @@ func TestConstructTrackerURL(t *testing.T) { DealID: "420", FloorValue: 4.4, FloorRuleValue: 2, + Piid: "1234", }, }, }, - want: "//t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&rwrd=1&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", + want: "//t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&piid=1234&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&rwrd=1&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", }, { name: "all_floors_details_in_tracker", @@ -522,10 +528,11 @@ func TestConstructTrackerURL(t *testing.T) { DealID: "420", FloorValue: 4.4, FloorRuleValue: 2, + Piid: "1234", }, }, }, - want: "//t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", + want: "//t.pubmatic.com/wt?adv=fb.com&af=banner&aps=0&au=adunit&bc=AppNexus1&bidid=6521&cds=traffic=media;age=23&di=420&dur=10&eg=4.3&en=2.5&fmv=test version&frv=2&fskp=0&fsrc=1&ft=1&fv=4.4&iid=98765&kgpv=adunit@300x250&orig=www.publisher.com&origbidid=6521&pdvid=1&pid=123&piid=1234&plt=1&pn=AppNexus&psz=300x250&pubid=12345&purl=www.abc.com&sl=1&slot=1234_1234&ss=1&tgid=1&tst=0", }, } for _, tt := range tests { @@ -823,8 +830,8 @@ func TestCreateTrackers(t *testing.T) { KGPV: "adunit-1@250x300", GrossECPM: 8.7, NetECPM: 8.7, - BidID: "bidID-1", - OrigBidID: "bidID-1", + BidID: "bidID-ext", + OrigBidID: "impID-1", AdSize: "250x300", AdDuration: 20, Adformat: "banner", @@ -833,6 +840,7 @@ func TestCreateTrackers(t *testing.T) { FloorValue: 6.4, FloorRuleValue: 4.4, DealID: "deal-id-1", + Piid: "bidID-1", }, Platform: 5, SSAI: "mediatailor", @@ -844,7 +852,7 @@ func TestCreateTrackers(t *testing.T) { KGPSV: "adunit-1@250x300", }, }, - TrackerURL: "https:?adv=domain.com&af=banner&aps=0&au=adunit-1&bc=pubmatic&bidid=bidID-1&cds=author%3Dhenry&di=deal-id-1&dur=20&eg=8.7&en=8.7&frv=4.4&ft=0&fv=6.4&iid=loggerIID&kgpv=adunit-1%40250x300&orig=publisher.com&origbidid=bidID-1&pdvid=1&pid=1234&plt=5&pn=pubmatic&psz=250x300&pubid=5890&purl=abc.com&sl=1&slot=impID-1_adunit-1&ss=1&ssai=mediatailor&tgid=1&tst=" + strconv.FormatInt(startTime, 10), + TrackerURL: "https:?adv=domain.com&af=banner&aps=0&au=adunit-1&bc=pubmatic&bidid=bidID-ext&cds=author%3Dhenry&di=deal-id-1&dur=20&eg=8.7&en=8.7&frv=4.4&ft=0&fv=6.4&iid=loggerIID&kgpv=adunit-1%40250x300&orig=publisher.com&origbidid=impID-1&pdvid=1&pid=1234&piid=bidID-1&plt=5&pn=pubmatic&psz=250x300&pubid=5890&purl=abc.com&sl=1&slot=impID-1_adunit-1&ss=1&ssai=mediatailor&tgid=1&tst=" + strconv.FormatInt(startTime, 10), Price: 8.7, PriceModel: "CPM", PriceCurrency: "USD", diff --git a/modules/pubmatic/openwrap/tracker/tracker_test.go b/modules/pubmatic/openwrap/tracker/tracker_test.go index e6e78fe0a32..4ad890969ce 100644 --- a/modules/pubmatic/openwrap/tracker/tracker_test.go +++ b/modules/pubmatic/openwrap/tracker/tracker_test.go @@ -48,7 +48,7 @@ func TestGetTrackerInfo(t *testing.T) { }, responseExt: openrtb_ext.ExtBidResponse{}, }, - want: "localhost:8080/wt?adv=&af=&aps=0&atts=1&au=%24%7BADUNIT%7D&bc=%24%7BBIDDER_CODE%7D&bidid=%24%7BBID_ID%7D&di=&eg=%24%7BG_ECPM%7D&en=%24%7BN_ECPM%7D&ft=0&iid=iid123&kgpv=%24%7BKGPV%7D&orig=www.publisher.com&origbidid=%24%7BORIGBID_ID%7D&pdvid=2&pid=1&plt=5&pn=%24%7BPARTNER_NAME%7D&psz=&pubid=123&purl=www.test.com&rwrd=%24%7BREWARDED%7D&sl=1&slot=%24%7BSLOT_ID%7D&ss=0&tgid=1&tst=" + strconv.FormatInt(startTime, 10), + want: "localhost:8080/wt?adv=&af=&aps=0&atts=1&au=%24%7BADUNIT%7D&bc=%24%7BBIDDER_CODE%7D&bidid=%24%7BBID_ID%7D&di=&eg=%24%7BG_ECPM%7D&en=%24%7BN_ECPM%7D&ft=0&iid=iid123&kgpv=%24%7BKGPV%7D&orig=www.publisher.com&origbidid=%24%7BORIGBID_ID%7D&pdvid=2&pid=1&piid=&plt=5&pn=%24%7BPARTNER_NAME%7D&psz=&pubid=123&purl=www.test.com&rwrd=%24%7BREWARDED%7D&sl=1&slot=%24%7BSLOT_ID%7D&ss=0&tgid=1&tst=" + strconv.FormatInt(startTime, 10), }, { name: "all_tracker_info_with_floors", @@ -87,7 +87,7 @@ func TestGetTrackerInfo(t *testing.T) { }, }, }, - want: "localhost:8080/wt?adv=&af=&aps=0&au=%24%7BADUNIT%7D&bc=%24%7BBIDDER_CODE%7D&bidid=%24%7BBID_ID%7D&di=&eg=%24%7BG_ECPM%7D&en=%24%7BN_ECPM%7D&fmv=version+1&fskp=1&fsrc=2&ft=1&iid=iid123&kgpv=%24%7BKGPV%7D&orig=www.publisher.com&origbidid=%24%7BORIGBID_ID%7D&pdvid=2&pid=1&plt=5&pn=%24%7BPARTNER_NAME%7D&psz=&pubid=123&purl=www.test.com&rwrd=%24%7BREWARDED%7D&sl=1&slot=%24%7BSLOT_ID%7D&ss=0&tgid=1&tst=" + strconv.FormatInt(startTime, 10), + want: "localhost:8080/wt?adv=&af=&aps=0&au=%24%7BADUNIT%7D&bc=%24%7BBIDDER_CODE%7D&bidid=%24%7BBID_ID%7D&di=&eg=%24%7BG_ECPM%7D&en=%24%7BN_ECPM%7D&fmv=version+1&fskp=1&fsrc=2&ft=1&iid=iid123&kgpv=%24%7BKGPV%7D&orig=www.publisher.com&origbidid=%24%7BORIGBID_ID%7D&pdvid=2&pid=1&piid=&plt=5&pn=%24%7BPARTNER_NAME%7D&psz=&pubid=123&purl=www.test.com&rwrd=%24%7BREWARDED%7D&sl=1&slot=%24%7BSLOT_ID%7D&ss=0&tgid=1&tst=" + strconv.FormatInt(startTime, 10), }, } for _, tt := range tests { From 2a8ff3c0a73b35f18eaf56ef6ba0ea9e38539da5 Mon Sep 17 00:00:00 2001 From: saurabh-narkhede Date: Tue, 19 Mar 2024 20:15:28 +0530 Subject: [PATCH 2/2] fix test cases --- modules/pubmatic/openwrap/auctionresponsehook_test.go | 10 +++++----- modules/pubmatic/openwrap/models/tracker.go | 1 + modules/pubmatic/openwrap/models/tracking.go | 1 + 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/modules/pubmatic/openwrap/auctionresponsehook_test.go b/modules/pubmatic/openwrap/auctionresponsehook_test.go index 251aa9316e4..fd755cf01d4 100644 --- a/modules/pubmatic/openwrap/auctionresponsehook_test.go +++ b/modules/pubmatic/openwrap/auctionresponsehook_test.go @@ -1477,7 +1477,7 @@ func TestAuctionResponseHookForEndpointWebS2S(t *testing.T) { Bid: []openrtb2.Bid{ { ID: "12345", - AdM: "
"}, + AdM: "
"}, }, }, }, @@ -1530,7 +1530,7 @@ func TestAuctionResponseHookForEndpointWebS2S(t *testing.T) { Bid: []openrtb2.Bid{ { ID: "12345", - AdM: "
"}, + AdM: "
"}, }, }, }, @@ -1749,7 +1749,7 @@ func TestOpenWrap_handleAuctionResponseHook(t *testing.T) { ID: "bid-id-1", ImpID: "Div1", Price: 5, - AdM: "
", + AdM: "
", Ext: json.RawMessage(`{"bidtype":0,"deal_channel":1,"dspid":6,"origbidcpm":8,"origbidcur":"USD","prebid":{"bidid":"bb57a9e3-fdc2-4772-8071-112dd7f50a6a","meta":{"adaptercode":"pubmatic","advertiserId":4098,"agencyId":4098,"demandSource":"6","mediaType":"banner","networkId":6},"targeting":{"hb_bidder_pubmatic":"pubmatic","hb_deal_pubmatic":"PUBDEAL1","hb_pb_pubmatic":"8.00","hb_size_pubmatic":"728x90"},"type":"banner","video":{"duration":0,"primary_category":"","vasttagid":""}}}`), }, }, @@ -1774,7 +1774,7 @@ func TestOpenWrap_handleAuctionResponseHook(t *testing.T) { DebugMessages: []string{`[{"PubID":5890,"ProfileID":0,"DisplayID":0,"VersionID":0,"DisplayVersionID":0,"SSAuction":0,"SummaryDisable":0,"LogInfoFlag":1,"SSAI":"","PartnerConfigMap":{"-1":{"displayVersionId":"1","refreshInterval":"30","rev_share":"0.5"},"123":{"bidderCode":"pubmatic","kgp":"_AU_@_W_x_H_","partnerId":"123","prebidPartnerName":"pubmatic","serverSideEnabled":"1","timeout":"200"}},"SupportDeals":false,"Platform":"web","LoggerImpressionID":"","ClientConfigFlag":1,"IP":"","TMax":0,"IsTestRequest":0,"ABTestConfig":0,"ABTestConfigApplied":0,"IsCTVRequest":false,"TrackerEndpoint":"","VideoErrorTrackerEndpoint":"","UA":"","Cookies":"","UidCookie":null,"KADUSERCookie":null,"ParsedUidCookie":null,"OriginCookie":"","Debug":true,"Trace":false,"PageURL":"","StartTime":0,"DevicePlatform":0,"Trackers":{"bid-id-1":{"Tracker":{"PubID":5890,"PageURL":"","Timestamp":0,"IID":"","ProfileID":"0","VersionID":"0","SlotID":"","Adunit":"","PartnerInfo":{"PartnerID":"pubmatic","BidderCode":"pubmatic","KGPV":"","GrossECPM":0,"NetECPM":0,"BidID":"bb57a9e3-fdc2-4772-8071-112dd7f50a6a","OrigBidID":"bid-id-1","AdSize":"0x0","AdDuration":0,"Adformat":"banner","ServerSide":1,"Advertiser":"","FloorValue":0,"FloorRuleValue":0,"DealID":"-1"},"RewardedInventory":0,"SURL":"","Platform":0,"SSAI":"","AdPodSlot":0,"TestGroup":0,"Origin":"","FloorSkippedFlag":null,"FloorModelVersion":"","FloorSource":null,"FloorType":0,"CustomDimensions":"","LoggerData":{"KGPSV":"","FloorProvider":"","FloorFetchStatus":null}},"TrackerURL":"https:?adv=\u0026af=banner\u0026aps=0\u0026au=\u0026bc=pubmatic\u0026bidid=bb57a9e3-fdc2-4772-8071-112dd7f50a6a\u0026di=-1\u0026eg=0\u0026en=0\u0026ft=0\u0026iid=\u0026kgpv=\u0026orig=\u0026origbidid=bid-id-1\u0026pdvid=0\u0026pid=0\u0026plt=0\u0026pn=pubmatic\u0026psz=0x0\u0026pubid=5890\u0026purl=\u0026sl=1\u0026slot=\u0026ss=1\u0026tgid=0\u0026tst=0","ErrorURL":"","Price":5,"PriceModel":"CPM","PriceCurrency":""}},"PrebidBidderCode":null,"ImpBidCtx":{"Div1":{"ImpID":"","TagID":"","Div":"","SlotName":"","AdUnitName":"","Secure":0,"BidFloor":0,"BidFloorCur":"","IsRewardInventory":null,"Banner":true,"Video":{"mimes":null},"Native":null,"IncomingSlots":null,"Type":"video","Bidders":{"pubmatic":{"PartnerID":123,"PrebidBidderCode":"pubmatic","MatchedSlot":"","KGP":"","KGPV":"","IsRegex":false,"Params":null,"VASTTagFlag":false,"VASTTagFlags":null}},"NonMapped":null,"NewExt":null,"BidCtx":{"bid-id-1":{"prebid":{"meta":{"adaptercode":"pubmatic","advertiserId":4098,"agencyId":4098,"demandSource":"6","mediaType":"banner","networkId":6},"type":"banner","bidid":"bb57a9e3-fdc2-4772-8071-112dd7f50a6a"},"refreshInterval":30,"crtype":"banner","dspid":6,"netecpm":5,"origbidcpm":8,"origbidcur":"USD","EG":0,"EN":0}},"BannerAdUnitCtx":{"MatchedSlot":"","IsRegex":false,"MatchedRegex":"","SelectedSlotAdUnitConfig":null,"AppliedSlotAdUnitConfig":null,"UsingDefaultConfig":false,"AllowedConnectionTypes":null},"VideoAdUnitCtx":{"MatchedSlot":"","IsRegex":false,"MatchedRegex":"","SelectedSlotAdUnitConfig":null,"AppliedSlotAdUnitConfig":null,"UsingDefaultConfig":false,"AllowedConnectionTypes":null},"BidderError":"","IsAdPodRequest":false}},"Aliases":null,"NewReqExt":null,"ResponseExt":{"responsetimemillis":{"pubmatic":8}},"MarketPlaceBidders":null,"AdapterThrottleMap":null,"AdUnitConfig":null,"Source":"","Origin":"","SendAllBids":false,"WinningBids":{"Div1":{"ID":"bid-id-1","NetEcpm":5,"BidDealTierSatisfied":false,"Nbr":null}},"DroppedBids":null,"DefaultBids":{},"SeatNonBids":{},"BidderResponseTimeMillis":{"pubmatic":8},"Endpoint":"","PubIDStr":"5890","ProfileIDStr":"","MetricsEngine":{},"ReturnAllBidStatus":true,"Sshb":"","DCName":"","CachePutMiss":0,"MatchedImpression":{"pubmatic":0},"CustomDimensions":null}]`}, }, err: nil, - bidResponse: json.RawMessage(`{"id":"12345","seatbid":[{"bid":[{"id":"bid-id-1","impid":"Div1","price":5,"adm":"\u003cimg src=\"http://ads.pubmatic.com/AdTag/728x90.png\"\u003e\u003c/img\u003e\u003cdiv style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"\u003e\u003cimg src=\"https://t.pubmatic.com/wt?adv=\u0026af=banner\u0026aps=0\u0026au=%2F43743431%2FDMDemo\u0026bc=appnexus\u0026bidid=4033c510-6d67-4af6-b53f-682ff1a580c3\u0026di=-1\u0026eg=14\u0026en=14\u0026frv=1.57\u0026ft=0\u0026fv=1.57\u0026iid=429d469d-8cfb-495a-9f0c-5f48aa0ede40\u0026kgpv=\u0026orig=ebay.com\u0026origbidid=718825584\u0026pdvid=1\u0026pid=22503\u0026plt=1\u0026pn=appnexus\u0026psz=728x90\u0026pubid=5890\u0026purl=http%3A%2F%2Febay.com%2Finte%2Fautomation%2Fs2s_activation%2Fbanner-with-gdpr-pubmatic-denied-defaultbidder.html%3Fprofileid%3D22503%26pwtv%3D1%26pwtvc%3D1%26appnexus_banner_fixedbid%3D14%26fixedbid%3D1%26debug%3D1\u0026sl=1\u0026slot=%2F43743431%2FDMDemo\u0026ss=1\u0026tgid=0\u0026tst=1704357774\"\u003e\u003c/div\u003e\u003cdiv style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"\u003e\u003cimg src=\"https:?adv=\u0026af=banner\u0026aps=0\u0026au=\u0026bc=pubmatic\u0026bidid=bb57a9e3-fdc2-4772-8071-112dd7f50a6a\u0026di=-1\u0026eg=0\u0026en=0\u0026ft=0\u0026iid=\u0026kgpv=\u0026orig=\u0026origbidid=bid-id-1\u0026pdvid=0\u0026pid=0\u0026plt=0\u0026pn=pubmatic\u0026psz=0x0\u0026pubid=5890\u0026purl=\u0026sl=1\u0026slot=\u0026ss=1\u0026tgid=0\u0026tst=0\"\u003e\u003c/div\u003e","ext":{"prebid":{"meta":{"adaptercode":"pubmatic","advertiserId":4098,"agencyId":4098,"demandSource":"6","mediaType":"banner","networkId":6},"type":"banner","bidid":"bb57a9e3-fdc2-4772-8071-112dd7f50a6a"},"refreshInterval":30,"crtype":"banner","dspid":6,"netecpm":5,"origbidcpm":8,"origbidcur":"USD"}}],"seat":"pubmatic"}],"ext":{"responsetimemillis":{"pubmatic":8},"matchedimpression":{"pubmatic":0},"loginfo":{"tracker":"?adv=\u0026af=\u0026aps=0\u0026au=%24%7BADUNIT%7D\u0026bc=%24%7BBIDDER_CODE%7D\u0026bidid=%24%7BBID_ID%7D\u0026di=\u0026eg=%24%7BG_ECPM%7D\u0026en=%24%7BN_ECPM%7D\u0026ft=0\u0026iid=\u0026kgpv=%24%7BKGPV%7D\u0026orig=\u0026origbidid=%24%7BORIGBID_ID%7D\u0026pdvid=0\u0026pid=0\u0026plt=0\u0026pn=%24%7BPARTNER_NAME%7D\u0026psz=\u0026pubid=5890\u0026purl=\u0026rwrd=%24%7BREWARDED%7D\u0026sl=1\u0026slot=%24%7BSLOT_ID%7D\u0026ss=0\u0026tgid=0\u0026tst=0"}}}`), + bidResponse: json.RawMessage(`{"id":"12345","seatbid":[{"bid":[{"id":"bid-id-1","impid":"Div1","price":5,"adm":"\u003cimg src=\"http://ads.pubmatic.com/AdTag/728x90.png\"\u003e\u003c/img\u003e\u003cdiv style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"\u003e\u003cimg src=\"https://t.pubmatic.com/wt?adv=\u0026af=banner\u0026aps=0\u0026au=%2F43743431%2FDMDemo\u0026bc=appnexus\u0026bidid=4033c510-6d67-4af6-b53f-682ff1a580c3\u0026di=-1\u0026eg=14\u0026en=14\u0026frv=1.57\u0026ft=0\u0026fv=1.57\u0026iid=429d469d-8cfb-495a-9f0c-5f48aa0ede40\u0026kgpv=\u0026orig=ebay.com\u0026origbidid=Div1\u0026pdvid=1\u0026pid=22503\u0026piid=bid-id-1\u0026plt=1\u0026pn=appnexus\u0026psz=728x90\u0026pubid=5890\u0026purl=http%3A%2F%2Febay.com%2Finte%2Fautomation%2Fs2s_activation%2Fbanner-with-gdpr-pubmatic-denied-defaultbidder.html%3Fprofileid%3D22503%26pwtv%3D1%26pwtvc%3D1%26appnexus_banner_fixedbid%3D14%26fixedbid%3D1%26debug%3D1\u0026sl=1\u0026slot=%2F43743431%2FDMDemo\u0026ss=1\u0026tgid=0\u0026tst=1704357774\"\u003e\u003c/div\u003e\u003cdiv style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"\u003e\u003cimg src=\"https:?adv=\u0026af=banner\u0026aps=0\u0026au=\u0026bc=pubmatic\u0026bidid=bb57a9e3-fdc2-4772-8071-112dd7f50a6a\u0026di=-1\u0026eg=0\u0026en=0\u0026ft=0\u0026iid=\u0026kgpv=\u0026orig=\u0026origbidid=Div1\u0026pdvid=0\u0026pid=0\u0026piid=bid-id-1\u0026plt=0\u0026pn=pubmatic\u0026psz=0x0\u0026pubid=5890\u0026purl=\u0026sl=1\u0026slot=\u0026ss=1\u0026tgid=0\u0026tst=0\"\u003e\u003c/div\u003e","ext":{"prebid":{"meta":{"adaptercode":"pubmatic","advertiserId":4098,"agencyId":4098,"demandSource":"6","mediaType":"banner","networkId":6},"type":"banner","bidid":"bb57a9e3-fdc2-4772-8071-112dd7f50a6a"},"refreshInterval":30,"crtype":"banner","dspid":6,"netecpm":5,"origbidcpm":8,"origbidcur":"USD"}}],"seat":"pubmatic"}],"ext":{"responsetimemillis":{"pubmatic":8},"matchedimpression":{"pubmatic":0},"loginfo":{"tracker":"?adv=\u0026af=\u0026aps=0\u0026au=%24%7BADUNIT%7D\u0026bc=%24%7BBIDDER_CODE%7D\u0026bidid=%24%7BBID_ID%7D\u0026di=\u0026eg=%24%7BG_ECPM%7D\u0026en=%24%7BN_ECPM%7D\u0026ft=0\u0026iid=\u0026kgpv=%24%7BKGPV%7D\u0026orig=\u0026origbidid=%24%7BORIGBID_ID%7D\u0026pdvid=0\u0026pid=0\u0026piid=\u0026plt=0\u0026pn=%24%7BPARTNER_NAME%7D\u0026psz=\u0026pubid=5890\u0026purl=\u0026rwrd=%24%7BREWARDED%7D\u0026sl=1\u0026slot=%24%7BSLOT_ID%7D\u0026ss=0\u0026tgid=0\u0026tst=0"}}}`), }, }, { @@ -1864,7 +1864,7 @@ func TestOpenWrap_handleAuctionResponseHook(t *testing.T) { want: want{ result: hookstage.HookResult[hookstage.AuctionResponsePayload]{}, err: nil, - bidResponse: json.RawMessage(`{"id":"12345","seatbid":[{"bid":[{"id":"bid-id-1","impid":"Div1","price":5,"adm":"\u003cVAST version=\"3.0\"\u003e\u003cAd\u003e\u003cWrapper\u003e\u003cImpression\u003e\u003c![CDATA[https:?adv=\u0026af=video\u0026aps=0\u0026au=\u0026bc=pubmatic\u0026bidid=bb57a9e3-fdc2-4772-8071-112dd7f50a6a\u0026di=-1\u0026eg=0\u0026en=0\u0026ft=0\u0026iid=\u0026kgpv=\u0026orig=\u0026origbidid=bid-id-1\u0026pdvid=0\u0026pid=0\u0026plt=0\u0026pn=pubmatic\u0026psz=0x0\u0026pubid=5890\u0026purl=\u0026sl=1\u0026slot=\u0026ss=1\u0026tgid=0\u0026tst=0]]\u003e\u003c/Impression\u003e\u003c/Wrapper\u003e\u003c/Ad\u003e\u003c/VAST\u003e","ext":{"prebid":{"meta":{"adaptercode":"pubmatic","advertiserId":4098,"agencyId":4098,"demandSource":"6","mediaType":"banner","networkId":6},"type":"video","bidid":"bb57a9e3-fdc2-4772-8071-112dd7f50a6a"},"refreshInterval":30,"crtype":"video","video":{"minduration":10,"maxduration":20,"skip":1,"skipmin":1,"skipafter":2,"battr":[1],"playbackmethod":[1]},"dspid":6,"netecpm":5,"origbidcpm":8,"origbidcur":"USD"}}],"seat":"pubmatic"}],"ext":{"responsetimemillis":{"pubmatic":8},"matchedimpression":{"pubmatic":0},"loginfo":{"tracker":"?adv=\u0026af=\u0026aps=0\u0026au=%24%7BADUNIT%7D\u0026bc=%24%7BBIDDER_CODE%7D\u0026bidid=%24%7BBID_ID%7D\u0026di=\u0026eg=%24%7BG_ECPM%7D\u0026en=%24%7BN_ECPM%7D\u0026ft=0\u0026iid=\u0026kgpv=%24%7BKGPV%7D\u0026orig=\u0026origbidid=%24%7BORIGBID_ID%7D\u0026pdvid=0\u0026pid=0\u0026plt=0\u0026pn=%24%7BPARTNER_NAME%7D\u0026psz=\u0026pubid=5890\u0026purl=\u0026rwrd=%24%7BREWARDED%7D\u0026sl=1\u0026slot=%24%7BSLOT_ID%7D\u0026ss=0\u0026tgid=0\u0026tst=0"}}}`), + bidResponse: json.RawMessage(`{"id":"12345","seatbid":[{"bid":[{"id":"bid-id-1","impid":"Div1","price":5,"adm":"\u003cVAST version=\"3.0\"\u003e\u003cAd\u003e\u003cWrapper\u003e\u003cImpression\u003e\u003c![CDATA[https:?adv=\u0026af=video\u0026aps=0\u0026au=\u0026bc=pubmatic\u0026bidid=bb57a9e3-fdc2-4772-8071-112dd7f50a6a\u0026di=-1\u0026eg=0\u0026en=0\u0026ft=0\u0026iid=\u0026kgpv=\u0026orig=\u0026origbidid=Div1\u0026pdvid=0\u0026pid=0\u0026piid=bid-id-1\u0026plt=0\u0026pn=pubmatic\u0026psz=0x0\u0026pubid=5890\u0026purl=\u0026sl=1\u0026slot=\u0026ss=1\u0026tgid=0\u0026tst=0]]\u003e\u003c/Impression\u003e\u003c/Wrapper\u003e\u003c/Ad\u003e\u003c/VAST\u003e","ext":{"prebid":{"meta":{"adaptercode":"pubmatic","advertiserId":4098,"agencyId":4098,"demandSource":"6","mediaType":"banner","networkId":6},"type":"video","bidid":"bb57a9e3-fdc2-4772-8071-112dd7f50a6a"},"refreshInterval":30,"crtype":"video","video":{"minduration":10,"maxduration":20,"skip":1,"skipmin":1,"skipafter":2,"battr":[1],"playbackmethod":[1]},"dspid":6,"netecpm":5,"origbidcpm":8,"origbidcur":"USD"}}],"seat":"pubmatic"}],"ext":{"responsetimemillis":{"pubmatic":8},"matchedimpression":{"pubmatic":0},"loginfo":{"tracker":"?adv=\u0026af=\u0026aps=0\u0026au=%24%7BADUNIT%7D\u0026bc=%24%7BBIDDER_CODE%7D\u0026bidid=%24%7BBID_ID%7D\u0026di=\u0026eg=%24%7BG_ECPM%7D\u0026en=%24%7BN_ECPM%7D\u0026ft=0\u0026iid=\u0026kgpv=%24%7BKGPV%7D\u0026orig=\u0026origbidid=%24%7BORIGBID_ID%7D\u0026pdvid=0\u0026pid=0\u0026piid=\u0026plt=0\u0026pn=%24%7BPARTNER_NAME%7D\u0026psz=\u0026pubid=5890\u0026purl=\u0026rwrd=%24%7BREWARDED%7D\u0026sl=1\u0026slot=%24%7BSLOT_ID%7D\u0026ss=0\u0026tgid=0\u0026tst=0"}}}`), }, }, } diff --git a/modules/pubmatic/openwrap/models/tracker.go b/modules/pubmatic/openwrap/models/tracker.go index 0b007471663..85e827aacf3 100644 --- a/modules/pubmatic/openwrap/models/tracker.go +++ b/modules/pubmatic/openwrap/models/tracker.go @@ -61,6 +61,7 @@ type Partner struct { FloorValue float64 FloorRuleValue float64 DealID string + Piid string } // LoggerData: this data to be needed in logger diff --git a/modules/pubmatic/openwrap/models/tracking.go b/modules/pubmatic/openwrap/models/tracking.go index f3dc93a271f..0d1af52c6a6 100644 --- a/modules/pubmatic/openwrap/models/tracking.go +++ b/modules/pubmatic/openwrap/models/tracking.go @@ -45,6 +45,7 @@ const ( TRKDealID = "di" TRKCustomDimensions = "cds" TRKATTS = "atts" + TRKPIID = "piid" ) // video error tracker url parameters