Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMTP check: enable_starttls => enable_starttls_auto ? #109

Open
johanlunds opened this issue Jun 8, 2021 · 0 comments
Open

SMTP check: enable_starttls => enable_starttls_auto ? #109

johanlunds opened this issue Jun 8, 2021 · 0 comments

Comments

@johanlunds
Copy link

I think the code in the following block should be changed to:

smtp.enable_starttls_auto if settings[:enable_starttls_auto]

https://github.com/ianheggie/health_check/blob/6cd2f91b522b7d4af16386f5a2e8f76300a8d6a2/lib/health_check/utils.rb#L147-L153

Docs of Net::SMTP explains the difference:

https://www.rubydoc.info/stdlib/net/2.1.0/Net/SMTP

Image 2021-06-08 at 5 50 01 PM

And you can also compare to how the mail gem used by ActionMailer/Rails does it:

https://github.com/mikel/mail/blob/4f56234f04eb041810641ee0dfd717034a59b9dc/lib/mail/network/delivery_methods/smtp.rb#L112-L131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanlunds