Clean up HTML and CSS #70
Comments
|
I would like to contribute if possible |
|
Sure! Please ask for help here if you need it.
…On Mon 28 Jan, 2019, 08:59 Matthew ***@***.*** wrote:
I would like to contribute if possible
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVj0ViClqZHPPQ2LALoJsF7IVPmESpuks5vHm6dgaJpZM4aUuA_>
.
|
|
Yea I am pretty new to contribution and this is for a university project. So far I've forked and cloned the project. Is there anything else I should know? Should i submit changes to the master branch or another other branch? |
|
Changes have to be submitted to the master branch. Your master to our master
…On Mon 28 Jan, 2019, 09:21 Matthew ***@***.*** wrote:
Yea I am pretty new to contribution and this is for a university project.
So far I've forked and cloned the project. Is there anything else I should
know? Should i submit changes to the master branch or another other branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVj0bCw6eDQs3Vjs7RtFoLbVX1TlOTOks5vHnPLgaJpZM4aUuA_>
.
|
|
Alright |
@theSage21 all the inline style code is to be removed ..is it?? There are 5 places where the inline style is used in index.html!!! |
|
Since we are using separate CSS files we can remove the inline styles.
…On Mon 28 Jan, 2019, 20:56 Gaurav sharma ***@***.*** wrote:
The html in index.html has some CSS classes which are note being used. We
need to clean it up. that file also has lots of inline style code. That has
to be removed.
@theSage21 <https://github.com/theSage21> all the inline style code is to
be removed ..is it?? There are 5 places where the inline style is used in
index.html!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVj0VuBldjPvQwBoTd-0RrXSurI6EQ7ks5vHxaMgaJpZM4aUuA_>
.
|
|
Can i take the issue and work on it ? |
|
sure @Priyanka-ashok. feel free to ask here if you have any doubt. you can also join the telegram group mentioned in README.md for general purpose. |
|
Is this issue resolved or something is needed to be done? |
|
it's open. A related merge request is there so I suggest that you take a look at that and see what discussion happened there. |
I reviewed #74 and except 1 change everything seems to be fine. I don't understand why it is not changed and merged till now. |
|
The way CSS is what I wanted to improve. No issues. I'll merge when I get a
chance
…On Sun 10 Feb, 2019, 19:52 HeroicHitesh ***@***.*** wrote:
it's open. A related merge request is there so I suggest that you take a
look at that and see what discussion happened there.
I reviewed #74 <#74> and except 1
change everything seems to be fine. I don't understand why it is not
changed and merged till now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVj0bySLq3fC-RLjVZVB8262KwnhpZpks5vMCshgaJpZM4aUuA_>
.
|
|
Would it be okay to merge both css files so it's just one css with everything? |
|
Definitely! But only if the CSS is used in both html files. Otherwise just
move the common content to one file and keep the unique content in a style
tag
…On Tue 19 Feb, 2019, 01:10 Matthew ***@***.*** wrote:
Would it be okay to merge both css files so it's just one css with
everything?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVj0dqBcjwOcUpLWz39wvZ9GDngQcGUks5vOwGTgaJpZM4aUuA_>
.
|
Maybe we can use html and css which is common in all html and css files in 1 base.html template using inline styling or do we need to do it in 2 different template files 1 for html and 1 for css? |
|
That is a matter of taste. I usually put it in a separate file so that other people can work on CSS separately and the PRs don't create merge conflicts. |
|
Well I'm a CS student and I feel that would be better for organization. I'll merge the css files, obviously the unique stuff for each html file will work as well, I will make that work, don't worry. In the end, having a clean HTML file is good and a CSS file to control all the looks. |
|
Sure! Go ahead! |
|
In index.html there is an anchor to the "here" that is href="#" |
|
Are you referring to this line? That is a placeholder. When we have something we will put it there. At least that's what it looks like. A better person to ask would be the person who wrote that. From the Blame window it looks like @rustagishubhi is the one who can answer that |
|
@adityabohra007 you can replace the # with the link where the criterias are mentioned |
|
Hi, Can I contribute to this project? Is there any other issues related to HTML and CSS. I am happy to work on them. Please let me know. Thanks |
|
Take a look at the issues
…On Wed 13 Mar, 2019, 18:00 ShumailAhmed123, ***@***.***> wrote:
Hi,
Can I contribute to this project? Is there any other issues related to
HTML and CSS. I am happy to work on them.
Please let me know.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVj0b2DVZcZKOzy-8-E920YG9N2-y8Qks5vWO94gaJpZM4aUuA_>
.
|
|
Hi, "Whoops! That unsubscribe link isn't valid for your account." Thanks |
|
I'm not sure what link you are clicking on.
Go to the github repo. Look at the issues. If I'm not wrong your typing
this in an issue right now.
Look at the discussion there and open a pull request with your changes in
it.
If you want to clarify something, read the Readme of the project and if
that does not answer your questions type it in the issue here
…On Wed 13 Mar, 2019, 18:36 ShumailAhmed123, ***@***.***> wrote:
Hi,
@theSage21 <https://github.com/theSage21>
When I click on the link. I get this error.
"Whoops! That unsubscribe link isn't valid for your account."
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVj0dkHJWMmR8BB9LxymZ1Wxv6YFXSjks5vWPftgaJpZM4aUuA_>
.
|
|
Is there any other html/css related stuff I could work on? |
|
you mean besides the issues that are already open? |
|
Yeah |
The html in
index.htmlhas some CSS classes which are note being used. We need to clean it up. that file also has lots of inline style code. That has to be removed.The text was updated successfully, but these errors were encountered: