Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File choosing button not translated #384

Open
dwt opened this issue Feb 20, 2019 · 3 comments
Open

File choosing button not translated #384

dwt opened this issue Feb 20, 2019 · 3 comments
Labels
BS5 Bootstrap 4 enhancement needs-pr should backport
Milestone
3.0.0

Comments

@dwt
Copy link
Contributor

dwt commented Feb 20, 2019

Looking at

deform/deform/static/scripts/file_upload.js

Line 28 in 010cb72

selectfile: 'Select file…',
and

deform/deform/static/scripts/file_upload.js

Line 29 in 010cb72

changefile: 'Change file…',
it seems those values are not translatable.

Which is sad. Can you do anything about it?
@stevepiercy
Copy link
Member

It looks like there is a way to do it. Here's a valid link that is referenced in file_upload.js. It appears that we should not use any strings in the JavaScript and put them in Deform's Chameleon template. I would support a PR and any changes needed to tests.

@stevepiercy
Copy link
Member

Bootstrap 4 has two implementations of translations.

@stevepiercy stevepiercy added this to the 3.0.0 milestone Aug 26, 2020
@stevepiercy
Copy link
Member

Just a note, the implementations for each version of Deform and Bootstrap have subtle differences. I would accept one PR for either version, along with functional tests. A deformdemo example would not be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BS5 Bootstrap 4 enhancement needs-pr should backport
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@dwt @stevepiercy