You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to screenshots in https://qafoolabs.com/profiler/blog/analyzing-xhprof-traces and what I can see in this repo, you report the number of calls to Composer\Autoload\ClassLoader::findFile as being non-easily optimizable, which is true.
However, it would be great to report calls to Composer\Autoload\ClassLoader::findFileWithExtension as well, which is easily optimizable. When using an optimized Composer autoloader, it will never be called (except if you register some namespaces dynamically as these won't be optimized by Composer), while they will be called a lot by findFile otherwise (accounting for 80% of the time of findFile in this case)
The text was updated successfully, but these errors were encountered:
According to screenshots in https://qafoolabs.com/profiler/blog/analyzing-xhprof-traces and what I can see in this repo, you report the number of calls to
Composer\Autoload\ClassLoader::findFile
as being non-easily optimizable, which is true.However, it would be great to report calls to
Composer\Autoload\ClassLoader::findFileWithExtension
as well, which is easily optimizable. When using an optimized Composer autoloader, it will never be called (except if you register some namespaces dynamically as these won't be optimized by Composer), while they will be called a lot byfindFile
otherwise (accounting for 80% of the time offindFile
in this case)The text was updated successfully, but these errors were encountered: