Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report usages of Composer\Autoload\ClassLoader::findFileWithExtension as easily optimizable #4

Open
stof opened this issue Dec 5, 2014 · 1 comment

Comments

@stof
Copy link
Contributor

stof commented Dec 5, 2014

According to screenshots in https://qafoolabs.com/profiler/blog/analyzing-xhprof-traces and what I can see in this repo, you report the number of calls to Composer\Autoload\ClassLoader::findFile as being non-easily optimizable, which is true.
However, it would be great to report calls to Composer\Autoload\ClassLoader::findFileWithExtension as well, which is easily optimizable. When using an optimized Composer autoloader, it will never be called (except if you register some namespaces dynamically as these won't be optimized by Composer), while they will be called a lot by findFile otherwise (accounting for 80% of the time of findFile in this case)

@beberlei
Copy link
Contributor

beberlei commented Dec 5, 2014

@stof Thanks for the hint. We have the optimized autoloader metric on our todo list as well so this will play well with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants