Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect and collapse functions should support DAGDependency inputs #39

Open
caleb-johnson opened this issue Sep 18, 2024 · 1 comment
Open

Collect and collapse functions should support DAGDependency inputs #39

caleb-johnson opened this issue Sep 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@caleb-johnson
Copy link
Collaborator

caleb-johnson commented Sep 18, 2024 •
edited
Loading

https://docs.quantum.ibm.com/api/qiskit/0.41/qiskit.transpiler.passes.CollectAndCollapse

As explained in docs for CollectAndCollapse, when commutative analysis is performed, a different DAG structure will be used internally, and this currently causes our collect function to fail, due to DAGDependency not having a find_bit method.
@caleb-johnson caleb-johnson added the bug Something isn't working label Sep 18, 2024
@caleb-johnson
Copy link
Collaborator Author

https://github.com/Qiskit/qiskit/blob/stable/0.23/qiskit/transpiler/passes/optimization/collect_linear_functions.py

May be ideas in this module for how to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caleb-johnson