Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve number reporting in add_categorical_bound_constraint #153

Open
jonashaag opened this issue Jun 6, 2023 · 2 comments
Open

Improve number reporting in add_categorical_bound_constraint #153

jonashaag opened this issue Jun 6, 2023 · 2 comments

Comments

@jonashaag
Copy link
Contributor

jonashaag commented Jun 6, 2023

I'm getting constraint failure messages like

6.288887928086567e-05% (20 out of 31802125)

and

1.0073226238812658% (320350 out of 31802125)

In both cases, using fewer decimal places would be nice I think. At the very least we shouldn't be showing scientific notation + % IMO.

For the counts, I think it would be nice to display them like Python does, ie. 320_350 out of 31_802_125.

@jonashaag
Copy link
Contributor Author

Also, are we giving the numbers in % here or in fraction? To me it looks like the distribution and default_bounds argument are in [0, 1] but the reported numbers are in [0, 100]...

@0xbe7a
Copy link

0xbe7a commented Jun 12, 2023

The parameters are in [0, 1] and the reported numbers are in [0, 100]. The reporting issue does not only exist here and we are working on fix, see #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants