Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

make RotationBlock composite block #39

Open
Roger-luo opened this issue May 5, 2019 · 1 comment
Open

make RotationBlock composite block #39

Roger-luo opened this issue May 5, 2019 · 1 comment
Labels
decision Need to make a decision discussion

Comments

@Roger-luo
Copy link
Member

It looks strange that:

julia> rot(chain(X, X), 0.1)
rot(nqubits: 1, datatype: Complex{Float64}
chain
├─ X gate
└─ X gate, 0.1)

it would be much better if it is just a container

julia> rot(chain(X, X), 0.1)
nqubits: 1, datatype: Complex{Float64}
rot(0.1)
└─ chain
          ├─ X gate
         └─ X gate, 0.1

since composite should simply means the composition of other blocks.

@Roger-luo Roger-luo added discussion decision Need to make a decision labels May 5, 2019
@Roger-luo Roger-luo changed the title make RotationBlock composite block and provide compact printing mode make RotationBlock composite block May 5, 2019
@GiggleLiu
Copy link
Member

Agree, but let’s make it slow. It is still confusing that whether a generator should be regarded as a gate or not. Let’s see more feedbacks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
decision Need to make a decision discussion
Projects
None yet
Development

No branches or pull requests

2 participants