Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg Integration Improvements #70

Open
dastardlyfinger323 opened this issue Feb 18, 2024 Discussed in #69 · 6 comments
Open

Gutenberg Integration Improvements #70

dastardlyfinger323 opened this issue Feb 18, 2024 Discussed in #69 · 6 comments

Comments

@dastardlyfinger323
Copy link

dastardlyfinger323 commented Feb 18, 2024

Discussed in #69

Include a toggle in the Library for viewing popular and random books atop the latest added, and increase the number of books fetched to at least 10 pages instead of 2 ("infinite" would be ideal).
OR
Have the Library display the most frequently downloaded books/authors for that day/week/month, and then add toggles to the Search for random, popular, and recently added books.

@tux-linux
Copy link
Contributor

Hi, these are good ideas, but unfortunately probably very hard to implement as we rely solely on regular expressions to parse Gutenberg catalog. You can have a look here and see for yourself:
https://github.com/Kobo-InkBox/rootfs/tree/master/usr/local/bin/gutenberg
As far as I can see, the csv catalog does not provide information for most popular books.

@Szybet
Copy link
Collaborator

Szybet commented Feb 20, 2024

Lol this method is cursed and is a meme
image

Jokes aside, there are libraries to parse html in a way like json - very convenient. So the problem is not "It's not possible" the problem is there is no people and time for that

@tux-linux
Copy link
Contributor

tux-linux commented Feb 20, 2024

Well, it's not parsing HTML, it's parsing CSV (thankfully)

@Szybet
Copy link
Collaborator

Szybet commented Feb 20, 2024

Thats's even worse, csv is a cool database format

@marzagheddon
Copy link

what about removing Project Gutemberg integration enterely? It doesn't make sense to have a botched implementation

@Szybet
Copy link
Collaborator

Szybet commented Feb 25, 2024

We plan to implement OPDS in the far future for a replacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants