Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: why deprecate the identifier of long, in favor of String? #101

Open
AndroidDeveloperLB opened this issue May 17, 2018 · 6 comments

Comments

@AndroidDeveloperLB
Copy link

Wouldn't a Long be better?
Or maybe String is actually what's used on popular calendars events ids ?

@jhoobergs
Copy link
Member

I think that the iOS calendar app uses strings, so they are not compatible with the Long we used.

@AndroidDeveloperLB
Copy link
Author

You mean the IOS calendar app uses a string from the server?

@jhoobergs
Copy link
Member

If you want to load the calendars from the phone on iOS, they use strings as id's. So if you want to show those events in the weekview, it would be hard.

@BerndSchrooten
Copy link
Member

I can understand why this sounds strange, but we use this library in conjunction with an iOS version in our React Native app. That's why @jhoobergs mentions iOS. However, also Google uses a String as the format of their event identifiers.

@AndroidDeveloperLB
Copy link
Author

How odd. Anyway, it's actually not a hard thing to have, to convert from unique String to unique long.
You just have to manage a HashMap<String,Long> .

@AndroidDeveloperLB
Copy link
Author

@jhoobergs I think it's better to remove the long-ids, then.
Why deprecate it, if String is the way to go for those popular calendars...
Whoever uses the library can just convert from Long to String, if that's needed. I don't think it's the role of the library to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants