Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: day&month formatting doesn't match current locale #98

Open
AndroidDeveloperLB opened this issue May 8, 2018 · 1 comment
Open

Comments

@AndroidDeveloperLB
Copy link

AndroidDeveloperLB commented May 8, 2018

Here:
alamkanak#500

AndroidDeveloperLB added a commit to AndroidDeveloperLB/Android-Week-View that referenced this issue May 8, 2018
Quivr#98
-added a feature to put text next to the week days
-added a feature to set only the week days to have a background, instead of week-days and all-day events.
-replaced Java "List" class with "MutableList" instead of Kotlin "List", to avoid possible crashes at runtime (because Kotlin "List" cannot be modified and is more restricted). That being said, I think in most cases, it's ok to use Kotlin "List", because in many cases you don't really need to modify the lists.
-some code cleaning and refactoring, including conversion of some fields to be Kotlin properties (setters and getters near the field itself)
@AndroidDeveloperLB
Copy link
Author

AndroidDeveloperLB commented May 8, 2018

Fixed here:
#97 (comment)

hermansje pushed a commit to hermansje/Android-Week-View that referenced this issue May 15, 2018
Quivr#98
-added a feature to put text next to the week days
-added a feature to set only the week days to have a background, instead of week-days and all-day events.
-replaced Java "List" class with "MutableList" instead of Kotlin "List", to avoid possible crashes at runtime (because Kotlin "List" cannot be modified and is more restricted). That being said, I think in most cases, it's ok to use Kotlin "List", because in many cases you don't really need to modify the lists.
-some code cleaning and refactoring, including conversion of some fields to be Kotlin properties (setters and getters near the field itself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant