Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate_crs should capture caller environment #27

Open
JosiahParry opened this issue Nov 8, 2023 · 0 comments
Open

validate_crs should capture caller environment #27

JosiahParry opened this issue Nov 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@JosiahParry
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

validate_crs() is used to create a spatialReference json object. However this can be called many levels deep inside of a function and the context may get lost.

Describe the solution you'd like

It would be useful to introduce error_call argument to allow us to pass in the caller environment in the case that validation fails.

Additional context

Additionally validate_crs() creates a list with one element "spatialReference" in most cases we subset directly into this element making the first element superfluous. It may make sense to adjust the function to to not contain this. Note that it would require adjusting all calls to this function.

@JosiahParry JosiahParry added the enhancement New feature or request label Nov 8, 2023
@JosiahParry JosiahParry transferred this issue from R-ArcGIS/arcgislayers Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant