Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump compiler warnings and fail CI on compiler warnings #598

Open
GeckoEidechse opened this issue Nov 15, 2023 · 0 comments
Open

Bump compiler warnings and fail CI on compiler warnings #598

GeckoEidechse opened this issue Nov 15, 2023 · 0 comments

Comments

@GeckoEidechse
Copy link
Member

In order to reduce our cases of UB and known bad behaviour we should increase compiler warning sensitivity. End goal would be /Wall or /W4.

Additionally we should fail CI if a new PR introduces additional compiler warnings.

As we currently already have some compiler warnings that are still unsolved we should either address them or mark them as ignored and fix them later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GeckoEidechse