Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when deleting a category #177

Open
mikev-cw opened this issue Nov 7, 2024 · 2 comments
Open

Bug when deleting a category #177

mikev-cw opened this issue Nov 7, 2024 · 2 comments
Labels
backend This is backend related bug Something isn't working

Comments

@mikev-cw
Copy link
Collaborator

mikev-cw commented Nov 7, 2024

When you delete a category used by at least a transaction or a recurring one, an inconsistency is created.

Speaking about recurring transactions, system should avoid this and let the user delete the recurring transaction first.
But what about regular transactions? We should avoid this as well, or let the user "change" the deleted category with a new one?

@mikev-cw mikev-cw added bug Something isn't working backend This is backend related labels Nov 7, 2024
@napitek
Copy link
Contributor

napitek commented Jan 7, 2025

or perhaps allow transactions without category, or with category “Uncategorized”?
Uncategorized transactions end up in limbo and must be browsed through one by one.
They are obviously not displayed until a category is chosen, except in a designated area

@theperu
Copy link
Collaborator

theperu commented Jan 7, 2025

Ideally I would allow the user to choose between two kinds of delete:

  • Soft Delete: the category is "marked" as deleted in the db but the previous transactions are still shown with that category.
  • Hard Delete: the category is removed from the db but and all the related transactions will change to uncategorized.

In both cases the related budgets and recurring transactions should be deleted and the deleted category should not be visible when the list of categories is displayed.
I would avoid removing the old transactions with a certain category since it might be confusing for the user and it could also make our job harder in the future if we want to optimize the calculation of the net worth or total expenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This is backend related bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants