Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: memory/build performance issues due to amdgpu-early-inline-all/amdgpu-function-calls in hipcc #235

Closed
AngryLoki opened this issue Dec 19, 2024 · 3 comments
Labels
generic Build error, or some other issue not caused by an LLVM bug Under Investigation

Comments

@AngryLoki
Copy link

AngryLoki commented Dec 19, 2024

Problem Description

Hi,

Right now hipcc adds -mllvm -amdgpu-early-inline-all=true -mllvm -amdgpu-function-calls=false both in Perl and binary versions:
https://github.com/search?q=repo%3AROCm%2Fllvm-project%20amdgpu-early-inline-all&type=code

In LLVM 18 release I noticed a major memory/performance regression due to these flags and reported to upstream llvm-project.
Performance was partially improved, but overall developers there say that these flags should not be used:
llvm#86332 (comment)

In https://github.com/search?q=org%3AROCm+SWDEV-442724+OR+SWDEV-459556+OR+SWDEV-460260&type=commits I see that these arguments were removed from ROCm/HIP and ROCm/clr. Could you remove them from hipcc too?

Operating System

Gentoo

CPU

GPU

ROCm Version

ROCm 6.3.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@ppanchad-amd ppanchad-amd added generic Build error, or some other issue not caused by an LLVM bug Under Investigation labels Jan 2, 2025
@ppanchad-amd
Copy link

Hi @AngryLoki. Internal ticket has been created to investigate your issue. Thanks!

@schung-amd
Copy link

Hi @AngryLoki, is this happening in the wild? The hipcc scripts were changed to not add these flags by default and should only add them if --hipcc-no-func-supp is passed: feba9fa.

@AngryLoki
Copy link
Author

Sorry, I missed the moment when funcSupp was enabled. The issue does not affect hipcc anymore. These flags are still added in various places (notably, composable_kernel), but there are no issues in hipcc. Thank you for correcting me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generic Build error, or some other issue not caused by an LLVM bug Under Investigation
Projects
None yet
Development

No branches or pull requests

3 participants