Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to update database #2

Open
jessejoe opened this issue Nov 5, 2015 · 3 comments
Open

Provide option to update database #2

jessejoe opened this issue Nov 5, 2015 · 3 comments

Comments

@jessejoe
Copy link

jessejoe commented Nov 5, 2015

Is there any reason to not provide a method to update the on disk database file, since this data changes quite frequently? Seems like the download.sh functionality could easily be put into a python module, which could then be used to download the most recent database (if requested) when initializing the database.

Would you be interested in a pull request for this?

@EpocDotFr
Copy link

EpocDotFr commented Apr 18, 2017

A simple pip install --upgrade maxminddb-geolite2 do the job (maxminddb is set as a PyPI dependency for maxminddb-geolite2).

@RR2DO2
Copy link
Owner

RR2DO2 commented Apr 25, 2017

Updating the data on the fly is a bit more involved, especially in cases where the package is a dependency on a shipping version. Releasing new versions of the package regularly is something I try to do (though it is entirely manual at the moment) but the downside is indeed that released versions of software that have the package as a dependency don't get the updated database files.

What the exact best update method is is not entirely clear to me yet, it might have to be some kind of download of a database to a temporary location on demand with a way to swap the reader out in a safe manner while a program is running.

@imewish
Copy link

imewish commented Jan 16, 2018

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants