Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch failed: config.yaml:17 #24

Closed
ubdbra001 opened this issue Aug 5, 2024 · 4 comments · Fixed by #25
Closed

patch failed: config.yaml:17 #24

ubdbra001 opened this issue Aug 5, 2024 · 4 comments · Fixed by #25

Comments

@ubdbra001
Copy link
Member

Hi @tdjames1

I tried following the instructions, got to applying the patch and received the following message:

error: CITATION.cff: already exists in index
error: patch failed: config.yaml:17
error: config.yaml: patch does not apply

I'm on windows and I started with the Rmd template from the carpentries if that makes any difference.

Thanks,

Dan

@tdjames1
Copy link
Collaborator

tdjames1 commented Aug 5, 2024

Thanks for noting this error, it's because the carpentries template has been adjusted to include a CITATION.cff file which it didn't at the time of developing the patch file (see #23). A quick fix would be to remove lines 1-30 inclusive of the patch file, then edit the CITATION.cff with the info indicated in that section of the patch file.

@ubdbra001
Copy link
Member Author

Got it, will give that a go and report back. Thanks!

@ubdbra001
Copy link
Member Author

ubdbra001 commented Aug 7, 2024

Had a go and that fixes the first part of the error:

error: CITATION.cff: already exists in index

The second part remained:

error: patch failed: config.yaml:17
error: config.yaml: patch does not apply

I had a bit of a tinker with it and it's because there's been a change to config.yaml that means that patch doesn't match up any more. Once I added the additional text it worked okay.

Would it be worth me regenerating the patch given I'm going to have to make these changes to my repo anyway?

@tdjames1
Copy link
Collaborator

tdjames1 commented Aug 7, 2024

If you'd be happy to do it that would be great!

I created the patch by creating a repo from the workbench template, making the various changes then running:

git diff daa55ad6609e.. > fair4rs_config.patch

where the daa55ad commit was the initial commit i.e. the unmodified workbench template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants