Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup #399

Open
ecwood opened this issue Jul 16, 2024 · 3 comments
Open

Code Cleanup #399

ecwood opened this issue Jul 16, 2024 · 3 comments
Assignees
@ecwood
Labels
housekeeping

Comments

@ecwood
Copy link
Collaborator

ecwood commented Jul 16, 2024

Just like with #390, there are lines of code that are no longer relevant or up to date.
@ecwood ecwood self-assigned this Jul 16, 2024
@ecwood
Copy link
Collaborator Author

ecwood commented Jul 16, 2024

I am considering removing the knowledge_type field from kg2-provided-by-curie-to-infores-curie.yaml, which stemmed from #77 but have never been used (and seem out of date now that we have knowledge_level and agent_type).

@ecwood
Copy link
Collaborator Author

ecwood commented Jul 16, 2024

I also need to check curies-to-urls-map.yaml. It seems strangely full.

ecwood added a commit that referenced this issue Jul 16, 2024
@ecwood
#399 to avoid confusion
cfd305e
@ecwood
Copy link
Collaborator Author

ecwood commented Jul 16, 2024

Also included in this should be items in multi ont/kg2_util that were removed with the separate ETL of UMLS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecwood ecwood

Labels
housekeeping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ecwood