Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some relabeled data not blacklisted #3

Open
HzEdward opened this issue Feb 21, 2024 · 4 comments
Open

Some relabeled data not blacklisted #3

HzEdward opened this issue Feb 21, 2024 · 4 comments

Comments

@HzEdward
Copy link

I have noticed that some of the mislabeled frames in the data/data.csv file are represented as "2" instead of "1" for the blacklist column, which prevents these frames from being excluded from the blacklist when the re-labeling parameter is "False". Could I know what is the reason for this?

@TheoPis
Copy link
Contributor

TheoPis commented Feb 21, 2024

Thanks for noting this.
blacklist = 2 in data.csv corresponds to originally problematic but relabelled frames.
As you mention, when you set blacklist=True and use_relabelled=False (in config) the relabelled frames are kept in the dataset. This is propably not the ideal behaviour for those flags. The reason this was never an issue for us, is that whenever we set blacklist=True we also set use_relabelled=True. Setting both flags to true gives us the filtered and relabelled version of the dataset, which is used for most of the experiments of the paper. Setting both flags to false gives you the originally released CADIS dataset.

@HzEdward
Copy link
Author

Also, in addition to the mislabeled frames you commented on, I still have found a number of mislabeled frames (but not commented in the csv file), especially for instruments. May I know what technique you used to identify the mislabeled data?

@TheoPis
Copy link
Contributor

TheoPis commented Feb 21, 2024

It was done by simply looking at frames with labels overlayed. It is entirely possible we did not find all of the mislabeled frames.

@HzEdward
Copy link
Author

Thanks for noting this. blacklist = 2 in data.csv corresponds to originally problematic but relabelled frames. As you mention, when you set blacklist=True and use_relabelled=False (in config) the relabelled frames are kept in the dataset. This is propably not the ideal behaviour for those flags. The reason this was never an issue for us, is that whenever we set blacklist=True we also set use_relabelled=True. Setting both flags to true gives us the filtered and relabelled version of the dataset, which is used for most of the experiments of the paper. Setting both flags to false gives you the originally released CADIS dataset.

Hi, I think I'm still a bit confused because I've noticed that some of the relabeled data is annotated as blacklisted = 2, while others are still annotated as blacklisted = 1. Could you explain the reason behind this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants