Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required MessageBlockID element in ResponseMessageGroup #3

Open
goekay opened this issue Jul 7, 2015 · 0 comments
Open

Required MessageBlockID element in ResponseMessageGroup #3

goekay opened this issue Jul 7, 2015 · 0 comments

Comments

@goekay
Copy link
Member

goekay commented Jul 7, 2015

All responses in ResponseMessageGroup [1] require the MessageBlockID field to be present. The thinking behind this is to make processing mainly for legacy systems easier, which cannot cope with huge message sizes. Since the field is also not optional, this has some consequences.

First, we always must set it to some dummy value, just to pass validation and make the recipient's parser happy. Secondly, a bizarre side effect is that even though there was a problem generating a response, and we send an IXSI error object back, this MessageBlockID field must still be included [2], which doesn't make sense. As it turns out, the schema needs some refinements in this area.

[1] https://github.com/RWTH-i5-IDSG/ixsi/blob/master/xml/IXSI.xsd#L1896
[2] https://github.com/RWTH-i5-IDSG/BikeMan/blob/sessionbased-auth/src/main/java/de/rwth/idsg/bikeman/ixsi/processor/subscription/complete/CompleteAvailabilityRequestProcessor.java#L60-L62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant