Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment to Firebase (pod deploy firebase) #7

Open
Rajan opened this issue May 8, 2018 · 8 comments
Open

Deployment to Firebase (pod deploy firebase) #7

Rajan opened this issue May 8, 2018 · 8 comments
Assignees
Labels

Comments

@Rajan
Copy link
Owner

Rajan commented May 8, 2018

We need a system that will replace all the axios calls with firebase CRUD embedded in the web pages. The goal is to turn our local SQLite based system into Firebase based system in the cloud.

We could create a command like below which runs a shell script to accomplish the task.

pod deploy firebase

@Rajan Rajan added the todo label May 8, 2018
@Rajan Rajan assigned s-kris and madguy02 and unassigned madguy02 May 21, 2018
@Rajan
Copy link
Owner Author

Rajan commented May 22, 2018

I've created the fbase branch where we can replace all axios calls with firebase calls and make it work without using local API. Later we can diff and patch using a shell script.

@Rajan
Copy link
Owner Author

Rajan commented May 23, 2018

The problem with creating a separate branch manually and pushing changes is that it'd always lag behind and we'll have trouble merging code all the time. So, It's better to just create a command that does following:

  • Create the fbase branch
  • Switches to fbase branch
  • Replaces Axios calls with Firebase calls
  • Commits changes to fbase branch

Now, we don't need to start the local API server and the Vuejs code will directly work with firebase.

@s-kris
Copy link
Collaborator

s-kris commented May 28, 2018

As we have discussed regarding replacing axios calls for fbase deployment, I've setup switch case for local db/fbase calls for now to make dev easier.

@khubo
Copy link
Collaborator

khubo commented May 29, 2018

just curious. Here instead of writing switch cases or any sort of hard logic, will it be better if adapter pattern is used instead? We can probably create a general interface that has methods like login, signup, addPost, fetchPost etc that can be injected into our main vue. By this different services can be written for firebase, local backend etc that implements this interface that can be injected to the client. Also by doing this , instead of hard cording in the code, we can use environment/config variables with webpack/bundler to properly inject the required service into the client . I think this can also make extension easier , that is working other backend logics like lambda/dynamodb etc.

@Rajan
Copy link
Owner Author

Rajan commented May 29, 2018

@khubo Agreed. Can you contribute this part?

@khubo
Copy link
Collaborator

khubo commented May 29, 2018

@Rajan sure, I would love to. can this wait till weekend ?

@Rajan
Copy link
Owner Author

Rajan commented May 29, 2018

sure @khubo

@Rajan
Copy link
Owner Author

Rajan commented May 29, 2018

@khubo I think this can wait as we have got a lot more features to be built out. Let's try to keep the code as simple as possible for now.

@Rajan Rajan assigned khubo and unassigned madguy02 May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants