Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: Save / Login functionality not as expected #843

Open
maxelkins opened this issue Dec 19, 2023 · 6 comments · May be fixed by #860
Open

Integration: Save / Login functionality not as expected #843

maxelkins opened this issue Dec 19, 2023 · 6 comments · May be fixed by #860

Comments

@maxelkins
Copy link
Contributor

maxelkins commented Dec 19, 2023

Current behaviour:

As a non-logged user:

  1. Click log in to save
  2. Logged in
  3. Need to click save again to save project.

Expected:

As a non-logged user:

  1. Click log in to save
  2. User logged in and Project is auto-remixed (user doesn't need to click save)
@maxelkins maxelkins added the QA label Dec 19, 2023
@sra405 sra405 added this to the Editor Integration (beta) milestone Dec 20, 2023
@sra405 sra405 self-assigned this Dec 21, 2023
Copy link
Contributor

@sra405
Copy link
Contributor

sra405 commented Jan 5, 2024

Pushed back to allow room to test and release separately. Currently it intermittently causes multiple auto remixes and blocks the editor loading via the web component. Most of the time it works great and provides a 1-to-1 auto remixing/fetching functionality but needs to be monitored during rollout.

@maxelkins
Copy link
Contributor Author

Save button added back in for now
#872

Please could we keep this ticket open though, as it would be good to pick up again when we have more time.

@sra405
Copy link
Contributor

sra405 commented Jan 10, 2024

Please could we keep this ticket open though, as it would be good to pick up again when we have more time.

Yea no worries, it's still open and on a sprint board 👍

sra405 added a commit that referenced this issue Jan 12, 2024
Allows mobile users to save their project and remix in place of auto
remixing (#843)
@sra405
Copy link
Contributor

sra405 commented Mar 1, 2024

removing from integration beta milestone as its part of normal BAU/bugs backlog

@sra405 sra405 removed this from the Editor Integration (beta) milestone Mar 1, 2024
@sra405 sra405 removed their assignment May 1, 2024
@MFarringtonRPF
Copy link

Propose to close this ticket, as it's covered in https://github.com/RaspberryPiFoundation/editor-standalone/issues/190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants