New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Theme settings #971

Open

magdalenajadach opened this issue Mar 14, 2024 · 1 comment

Labels

Contributor

magdalenajadach commented Mar 14, 2024

Currently, styles related to themes are coming from various places.

For Example, WC has styles applied:

WebComponent.scss
App.scss
Editor.scss

which is messy and not consistent

Contributor

maxelkins commented Mar 14, 2024 •

edited

Loading

@magdalenajadach to clarify would these definitions be correct?

Editor.scss
- Meant to be before styles related to the the actual editor i.e. (The editor shown here)
WebComponent.scss
- Styles what were specific to the WebComponent implementation of the Editor before we decided that they should be the same.
App.scss
- Styles related to the Editor site, like the landing page, projects page, etc. Aka stuff that that now won't be in the WebComponent.

MFarringtonRPF added the tech debt label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment