From bf225d26b399fcc3fd258d7acbdedb1e76154b8e Mon Sep 17 00:00:00 2001 From: Walker Selby Date: Thu, 2 Nov 2023 15:38:06 +0000 Subject: [PATCH 1/2] Use HTTPS rather than HTTP --- src/main/java/SkyHanniInstallerFrame.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/SkyHanniInstallerFrame.java b/src/main/java/SkyHanniInstallerFrame.java index fa8868254b12..ee94729ef892 100644 --- a/src/main/java/SkyHanniInstallerFrame.java +++ b/src/main/java/SkyHanniInstallerFrame.java @@ -430,7 +430,7 @@ public void mouseClicked(MouseEvent e) { if (e.getSource() == getForgeTextArea()) { try { Desktop.getDesktop().browse(new URI( - "http://files.minecraftforge.net/maven/net/minecraftforge/forge/index_1.8.9.html")); + "https://files.minecraftforge.net/maven/net/minecraftforge/forge/index_1.8.9.html")); } catch (IOException | URISyntaxException ex) { showErrorPopup(ex); } @@ -700,4 +700,4 @@ public enum OperatingSystem { MACOS, UNKNOWN } -} \ No newline at end of file +} From 993253d4c7afdb12aea77676f06651b34b895fd8 Mon Sep 17 00:00:00 2001 From: Walker Selby Date: Wed, 6 Dec 2023 14:11:43 -0800 Subject: [PATCH 2/2] Docs: Contributing Regex Information (#711) --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fb5a7e1e6c30..ad967170cc40 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,6 +73,8 @@ You can write in the description of the pr the wording for the changelog as well - Don't forget to add `@FeatureToggle` to new standalone features (not options to that feature) in the config. - Do not use `e.printStackTrace()`, use `CopyErrorCommand.logError(e, "explanation for users")` instead. - Do not use `MinecraftForge.EVENT_BUS.post(event)`, use `event.postAndCatch()` instead. +- Do not use `toRegex()`, use `toPattern()` instead. +- Please use Regex instead of String comparison when it is likely Hypixel will change the message in the future. ## Software Used in SkyHanni