Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

. #117

Closed
ghost opened this issue Jul 9, 2024 · 5 comments · Fixed by #118
Closed

. #117

ghost opened this issue Jul 9, 2024 · 5 comments · Fixed by #118

Comments

@ghost
Copy link

ghost commented Jul 9, 2024

.

@RePod
Copy link
Owner

RePod commented Jul 9, 2024

re: #115 (comment)
The 109 version requirement is for Firefox and similar, which I am noticing an issue with but not on Chrome 126.

If possible try updating Chrome although MV3 support was recommend as far back as 88. Barring that, Ctrl+Shift+J to get logs from the console.

Edit: Convenient. The problem with Firefox is it did not support the MAIN world for injecting the scripts... until today with 128!

@RePod
Copy link
Owner

RePod commented Jul 9, 2024

PSDLE now requires Windows 10/11 browsers?

The extensions maybe due to upgrading to Manifest V3 and especially in Firefox's case for dragging out supporting MAIN which is key to how the extensions inject PSDLE. The manual/userscript versions should be fine whenever I send them out.

Also Linux (not sponsored).

Is there a way to revert back to extension v4.1.4?

It's more involved and not permanent, but:

  • Download the older repo
  • Move:
    • _src/base/valkyrie/psdle.valkyrie.includes.js to _src/chrome/psdle/js/psdle.valkyrie.js
    • _src/base/gotham/psdle.gotham.includes.js to _src/chrome/psdle/js/psdle.gotham.js
  • Navigate to chrome://extensions
  • Enable Developer Mode in the top right
  • Load Unpacked in the top left
  • Select the _src/chrome/psdle folder (you'll see the _locales/icons/js folders)

I don't endorse or confirm the safety of third-party extensions mirrors but that may also be an option.
I could roll back the extension on the stores but this delays the inevitable.

chrome.js:1 PSDLE Chrome | radio static I'm in Window {window: Window, self: Window, document: document, name: '', location: Location, …} #document
psdle.gotham.js:9 PSDLE 4.2.0 2024-07-08
psdle.gotham.js:15 Uncaught TypeError: Cannot read properties of undefined (reading 'appProps')

This fortunately is not an extension error but rather something with Gotham which is weird since I didn't touch it aside from how it's injected now. I'll try to get my hands on a version of Chrome 109 for further testing. Logs from a Transaction History/Payment Management run would also be good.

Seems Chrome 109 also does not respect MAIN world.

@RePod RePod changed the title No longer usable after update v4.2.0 Runs in Isolated world on Chrome 109/Win7 Jul 9, 2024
@RePod
Copy link
Owner

RePod commented Jul 9, 2024

Please try the above instructions but with this zip.
It's still MV3, as that was not the main issue, but it's back to injecting like before despite being less elegant.

EDIT: are you sure the minimum requirement for Firefox is 109? Like i said, i'm on W7, i have 115esr, but it's stuck on v4.1.4 and from the Firefox Add-Ons page it asks me to download a newer version of the browser in order to use v4.2.0.

FF109 is the minimum version for MV3 but I preemptively raised it on AMO to 128 when I realized in an earlier comment the support needed came out today. If I push out 4.2.1 it should drop back to 109.

@RePod
Copy link
Owner

RePod commented Jul 9, 2024

Payment Management being expanded is intended. Previously the width of the drawer was set to 100% but now it's 95% so it can also be closed normally.

The PS_PLUS_REQUIRED has now appeared for me on games I know I purchased while also failing to load their icons. It's beyond me. The distinction might need to be changed because I'm not getting PS+ to check.

The original goal was to migrate to MV3 but I would like to eventually, within the next 10 years, return to injecting the script as intended.

@RePod RePod closed this as completed in #118 Jul 9, 2024
@RePod
Copy link
Owner

RePod commented Jul 9, 2024

All three at once though the the label chosen for PSDLE might be inaccurate. I cannot force the information to exist so that's the extent of my concern.

@ghost ghost changed the title Runs in Isolated world on Chrome 109/Win7 . Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant