-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Preview patch list before selecting application #1418
Comments
The patch selector view model can include a readOnly boolean for that. |
I guess if the app is installed and the manager has root perms or it isnt a split apk then when the user goes to see the patches preview they should just be taken straight to the patch selection menu without it being read-only. Also, when it is in read-only mode, the checkbox and buffer on the patch cards can be removed Edit: Actually, perhaps the full functionality of the patch selection menu should be kept and the user will be allowed to save the patch selection and options for that app (even though it cant be patched currently) And when the user presses 'Done' after selecting the patches they should ofc be brought back to the application selection screen. |
This would introduce a new flow of action. Usually, you select an app, which brings you back to the patcher screen, and then you select the patches. Here, it would skip bringing you back to the patcher screen, which is inconsistent in behavior to the current flow of action. So either you display the patches screen readonly with the option to go back to the app selector screen, or you change the flow from "select app -> go back -> select patches" to "select app -> select patches" everywhere. |
Feature description
Allow the user to see the list of patches for an app without needing to have a non-split app installed.
(This demonstration above is a terrible design. A better one may be to add a new line in the card which will have the amount of patches, and then that can be clickable.
Edit: Another possible design is to give the option when the user tries selecting the app card.
A new popup would need to be made for apps that arent installed.
Motivation
The user should not need to go to revanced.app/patches to see what patches are available for an app that is installed as a split APK or not installed on their device.
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: