Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Preview patch list before selecting application #1418

Closed
4 tasks done
KobeW50 opened this issue Oct 23, 2023 · 4 comments · May be fixed by #1409
Closed
4 tasks done

feat: Preview patch list before selecting application #1418

KobeW50 opened this issue Oct 23, 2023 · 4 comments · May be fixed by #1409
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Oct 23, 2023

Feature description

Allow the user to see the list of patches for an app without needing to have a non-split app installed.

Screenshot_20231023_101858_ReVanced Manager

(This demonstration above is a terrible design. A better one may be to add a new line in the card which will have the amount of patches, and then that can be clickable.

photostudio_1698071671601

Edit: Another possible design is to give the option when the user tries selecting the app card.

SmartSelect_20231023_143643_ReVanced Manager.jpg

A new popup would need to be made for apps that arent installed.

Motivation

The user should not need to go to revanced.app/patches to see what patches are available for an app that is installed as a split APK or not installed on their device.

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label Oct 23, 2023
@oSumAtrIX
Copy link
Member

The patch selector view model can include a readOnly boolean for that.

@KobeW50
Copy link
Contributor Author

KobeW50 commented Oct 23, 2023

I guess if the app is installed and the manager has root perms or it isnt a split apk then when the user goes to see the patches preview they should just be taken straight to the patch selection menu without it being read-only.

Also, when it is in read-only mode, the checkbox and buffer on the patch cards can be removed

SmartSelect_20231023_111944_ReVanced Manager.jpg

Edit: Actually, perhaps the full functionality of the patch selection menu should be kept and the user will be allowed to save the patch selection and options for that app (even though it cant be patched currently)

And when the user presses 'Done' after selecting the patches they should ofc be brought back to the application selection screen.

@oSumAtrIX
Copy link
Member

they should just be taken straight to the patch selection menu without it being read-only.

This would introduce a new flow of action. Usually, you select an app, which brings you back to the patcher screen, and then you select the patches. Here, it would skip bringing you back to the patcher screen, which is inconsistent in behavior to the current flow of action. So either you display the patches screen readonly with the option to go back to the app selector screen, or you change the flow from "select app -> go back -> select patches" to "select app -> select patches" everywhere.

@Ushie Ushie linked a pull request Oct 25, 2023 that will close this issue
3 tasks
@KobeW50
Copy link
Contributor Author

KobeW50 commented Nov 29, 2024

Closing in favor of #2093

Also #2310 is relevant

@KobeW50 KobeW50 closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants