Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Do not permit to proceed patching when required patch options are unset #1555

Closed
4 tasks done
oSumAtrIX opened this issue Dec 5, 2023 · 0 comments · Fixed by #2378
Closed
4 tasks done

bug: Do not permit to proceed patching when required patch options are unset #1555

oSumAtrIX opened this issue Dec 5, 2023 · 0 comments · Fixed by #2378
Assignees
Labels
Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Dec 5, 2023

Bug report

When the user tries to patch an app and select patches that have options but have not set them, they should not be able to proceed. Instead, the app should behave in the same way as the current version.

The user will miss options without knowing they must be set.

Additional context

Ideally, the behaviour of the current version of ReVanced Manager should be implemented. A popup if you try to patch, when you try to confirm the selection of patches without the options set or save options without a value even when required. As a reference, it is suggested that the current version of ReVanced Manager be looked into for the current behavior.

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@oSumAtrIX oSumAtrIX added Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager labels Dec 5, 2023
@Axelen123 Axelen123 moved this to 📋 Backlog in Development of ReVanced Jun 23, 2024
@oSumAtrIX oSumAtrIX added Bug report Something isn't working and removed Feature request Requesting a new feature that's not implemented yet labels Jul 13, 2024
@oSumAtrIX oSumAtrIX changed the title feat: Do not permit to proceed patching when required patch options are unset bug: Do not permit to proceed patching when required patch options are unset Jul 13, 2024
@Axelen123 Axelen123 self-assigned this Jul 14, 2024
@oSumAtrIX oSumAtrIX moved this from 📋 Backlog to 🏗 In progress in Development of ReVanced Jul 18, 2024
@Axelen123 Axelen123 assigned CnC-Robert and unassigned Axelen123 Aug 16, 2024
@Axelen123 Axelen123 linked a pull request Jan 3, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Done in Development of ReVanced Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants