Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

rx script fails when given --file all.js param #5

Open
jfsiii opened this issue Jan 10, 2015 · 0 comments
Open

rx script fails when given --file all.js param #5

jfsiii opened this issue Jan 10, 2015 · 0 comments

Comments

@jfsiii
Copy link
Contributor

jfsiii commented Jan 10, 2015

> rx --file $(npm root -g)/rx-cli/all.js
Requested operator aggregate
Adding operator aggregate
Adding operator scan
Adding operator startwith
Adding operator fromarray
Adding operator finalvalue
Requested operator all
Adding operator all
Adding operator where
Adding operator any
Requested operator amb
Adding operator amb
Adding operator frompromise
Requested operator and
Adding operator and
Adding operator nativemap
Adding operator activeplan

/opt/twitter/lib/node_modules/rx-cli/bin/rx:89
        locations.push.apply(locations, methodData.source);
                                                  ^
TypeError: Cannot read property 'source' of undefined
    at recursivelyAdd (/opt/twitter/lib/node_modules/rx-cli/bin/rx:89:51)
    at /opt/twitter/lib/node_modules/rx-cli/bin/rx:93:11
    at Array.forEach (native)
    at recursivelyAdd (/opt/twitter/lib/node_modules/rx-cli/bin/rx:92:30)
    at /opt/twitter/lib/node_modules/rx-cli/bin/rx:75:5
    at Array.forEach (native)
    at loadMethods (/opt/twitter/lib/node_modules/rx-cli/bin/rx:57:11)
    at Object.<anonymous> (/opt/twitter/lib/node_modules/rx-cli/bin/rx:48:19)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)

Several operators in lib/dependencies.js have values in their dependsOn array which aren't keys in operators.

For example, activeplan is listed in the dependsOn array for and, thendo, and when operators, but isn't an entry in operators

I did some list comparisons between all.js and dependencies.js and believe the missing entries are activeplan, behaviorsubject, empy (typo?), joinobserver, pattern, plan, replaysubject.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant