Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move development_clevis() function in pkcs11 tests earlier #27

Closed
kokesak opened this issue Dec 3, 2024 · 2 comments
Closed

Move development_clevis() function in pkcs11 tests earlier #27

kokesak opened this issue Dec 3, 2024 · 2 comments
Assignees

Comments

@kokesak
Copy link
Collaborator

kokesak commented Dec 3, 2024

I suggest moving the development_clevis() - https://github.com/RedHat-SP-Security/clevis-tests/blob/master/Sanity/pkcs11/basic/runtest.sh#L58, earlier in the setup phase.

The reason is that we have some checks that verify the package presence in the beginning (https://github.com/RedHat-SP-Security/clevis-tests/blob/master/Sanity/pkcs11/basic/runtest.sh#L37) but the installation of the package much later. It makes no sense to have it there, in case the package is not installed we should install it. The check fails in case the package is not installed, so it this function may never do what it is supposed to do. We could also figure out a better solution overall regarding the correct package installation.

@sarroutbi
Copy link
Contributor

@kokesak : can we consider this done in #19? I forgot to include it in the Resolves field of the PR

@kokesak
Copy link
Collaborator Author

kokesak commented Feb 4, 2025

Yes, it is done. Closing this issue as it was fixed

@kokesak kokesak closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants