Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page visual requirements #215

Open
Hyperkid123 opened this issue Mar 25, 2021 · 7 comments
Open

Landing page visual requirements #215

Hyperkid123 opened this issue Mar 25, 2021 · 7 comments
Assignees

Comments

@Hyperkid123
Copy link
Contributor

Hyperkid123 commented Mar 25, 2021

Please post any requirements regarding the appearance of the landing pages here. I will add and update images of current progress. It would be better to consolidate all the requirements in one place and don't block the dev work. There are more important things to do before we can make it look perfect. These initial fixes are there to stop other teams from complaining that the landing page looks poopy.

Estate section:

screenshot-ci foo redhat com_1337-2021 03 24-15_21_32

Recommendation section

scteenshot-recs

Footer section

TBD

cc @KendraMar

@Hyperkid123
Copy link
Contributor Author

Estate

  • There should be a max of 6 items in the Estate section
  • items should not stretch in the widest viewport, but have a fixed width , with the overall width limited to 1160px (1450px total with the nav)
  • items can stretch at the intermediate layout with 3 (out of 6) items per line
  • Mobile view should go horizontal like it was before

taken from: #213 (comment)

Recomendation

  • Can we make the buttons the same length? Hoping no one went crazy with long titles.

@Hyperkid123
Copy link
Contributor Author

items should not stretch in the widest viewport, but have a fixed width , with the overall width limited to 1160px (1450px total with the nav)

@epwinchell @KendraMar Is there any specific reason why we limit the max-width? I am able to show 6 items always in one column at any page size (will go down on breakpoints). I am not sure that limiting the width of the container is a good move. Some apps have the text longer than just one or two words and we might end up with a nice noodle of a description and push the rest of the content down.

Here is an example:
screenshot-ci foo redhat com_1337-2021 03 25-10_05_38

@ryelo
Copy link
Member

ryelo commented Mar 25, 2021

We limit max width of the section entirely so that the bottom section of the console page can be seen on the majority of layouts without scrolling. Too many people are against having that bottom section below the fold, so we need to make sure it has the space it needs so users know there is information down there.

@Hyperkid123
Copy link
Contributor Author

Ok its a simple adjustment I was just curious why.

@Hyperkid123
Copy link
Contributor Author

I've created a new Jira task for the finishing touches: https://issues.redhat.com/browse/RHCLOUD-13189 @epwinchell if you want to take it to feel free. @rvsia and I plan to do some JS refracting of the API tomorrow. But I am not sure if it's worth starting working on the visual detailing before we have the necessary information from applications. We are still missing permissions, icons, states, etc. It won't be 100% complete before then.

@epwinchell
Copy link
Contributor

epwinchell commented Mar 25, 2021

Here's the original doc they specs the top section. https://docs.google.com/document/d/1v7GWs-bD6Oret9kaZs06yWsM_4qwT0ZtkLiKystjeAE/ Spacing between Estate items are spelled out, giving us the total fixed width. We ended up dropping the extra spacing between "Application Services", "Platforms:, etc. because we don't know how many sections are actually coming in when dynamic, only that we can accommodate 6 times.

Screen Shot 2021-03-25 at 11 31 15 AM

@KendraMar
Copy link

KendraMar commented Mar 25, 2021

Kendra needs to provide priority/sev icons for recommendations + type icons for the config/try/learn section. It's on my list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants