From 01fd1e36d0e55cf88d338ec6168496ccd6b15acf Mon Sep 17 00:00:00 2001 From: Nikhil Dhandre Date: Mon, 20 Jan 2025 12:24:26 +0530 Subject: [PATCH 1/2] Python 3.13 test run --- .github/workflows/tests.yaml | 2 +- pyproject.toml | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 3bb4f30..980d459 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -16,7 +16,7 @@ jobs: fail-fast: false matrix: browser: [chrome, firefox] - python-version: ["3.9", "3.11", "3.12"] + python-version: ["3.11", "3.12", "3.13"] steps: - name: Pull selenium-standalone run: podman pull selenium/standalone-${{ matrix.browser }}:4.9 diff --git a/pyproject.toml b/pyproject.toml index d16b473..017d3af 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -5,6 +5,9 @@ classifiers = [ "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", + "Programming Language :: Python :: 3.11", + "Programming Language :: Python :: 3.12", + "Programming Language :: Python :: 3.13", "Topic :: Software Development :: Libraries :: Python Modules", "Topic :: Software Development :: Quality Assurance", "Topic :: Software Development :: Testing", From f653f39966c7c49834473a5110e10b3616f6564f Mon Sep 17 00:00:00 2001 From: Nikhil Dhandre Date: Fri, 24 Jan 2025 13:08:25 +0530 Subject: [PATCH 2/2] Fix split button tests --- testing/components/menus/test_menu_toggle.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/testing/components/menus/test_menu_toggle.py b/testing/components/menus/test_menu_toggle.py index 45df020..e34d69f 100644 --- a/testing/components/menus/test_menu_toggle.py +++ b/testing/components/menus/test_menu_toggle.py @@ -2,13 +2,13 @@ from widgetastic_patternfly5 import SplitButtonDropdown -TESTING_PAGE_URL = "https://www.patternfly.org/components/menus/menu-toggle" +TESTING_PAGE_URL = "https://v5-archive.patternfly.org/components/menus/menu-toggle" @pytest.fixture( params=[ - "ws-react-c-menu-toggle-split-button-toggle-with-checkbox", - "ws-react-c-menu-toggle-split-button-toggle-with-text-label", + "ws-react-c-menu-toggle-split-toggle-with-checkbox", + "ws-react-c-menu-toggle-split-toggle-with-checkbox-and-toggle-text-label", ], ids=["without_text", "with_text"], ) @@ -20,14 +20,13 @@ def split_button_dropdown(request, browser): return split_drop, request.param -@pytest.mark.flaky(reruns=3, reruns_delay=2) def test_split_button_dropdown(split_button_dropdown): dropdown, dropdown_type = split_button_dropdown assert dropdown.is_displayed assert dropdown.is_enabled assert dropdown.check() assert dropdown.selected - expected_text = "10 selected" if "with-text-label" in dropdown_type else "" + expected_text = "10 selected" if "text-label" in dropdown_type else "" assert dropdown.read() == expected_text assert dropdown.uncheck()