Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rmlines does does not handle highlighters correctly #12

Open
jantb opened this issue Jan 14, 2025 · 7 comments
Open

Rmlines does does not handle highlighters correctly #12

jantb opened this issue Jan 14, 2025 · 7 comments
Labels
bug Something isn't working planned This behavior is intended / The Feature is planned reproduced The issue has been reproduced and a fix is on the way

Comments

@jantb
Copy link

jantb commented Jan 14, 2025

Rmlines reads the pen color of the highlighter as value 9. the pen color enum only goes to number 8.

Create a notebook with a single highlight. Open the file on moss-desktop. Notice the highlight is missin from the note view. When placing a debug inside the code that parses the pen_color it shows the number 9. Then it tries to convert it to an enum, and fails.

It should record the penstroke with color.

Desktop:

  • OS: mac
  • Version main source
  • Architecture
  • Python version 3.13
@JustRedTTG
Copy link
Collaborator

Which highlighter color are you drawing? And what is your tablet version? Moss doesn't have full support for newer versions but I am looking to support it, you can submit your rm file for testing too, we are looking for testers in the discord server too.

@jantb
Copy link
Author

jantb commented Jan 14, 2025

Yellow and blue, both get color number 9 in the rm_lines; Version 3.17.0.62 on a reMarkable pro. The newest beta with shapes.

@JustRedTTG
Copy link
Collaborator

Yellow and blue, both get color number 9 in the rm_lines; Version 3.17.0.62 on a reMarkable pro. The newest beta with shapes.

Please share a PNG and the .rm file of the document and I'll add them in

@jantb
Copy link
Author

jantb commented Jan 14, 2025

Screenshot 2025-01-14 at 08 02 43
Screenshot 2025-01-14 at 08 01 00
notebooks.zip

Here are the files and screenshots

@JustRedTTG JustRedTTG added bug Something isn't working needs testing The issue or feature needs to be tested. labels Jan 14, 2025
@jantb
Copy link
Author

jantb commented Jan 14, 2025

https://github.com/ricklupton/rmscene/blob/9df89e2c9941479e87e500b3dad9e4d3b2a782b8/src/rmscene/scene_items.py#L58

RmScene has some more code in the PenColor enum, but is seems a bit incomplete since they cant figure out the highlight color

@JustRedTTG JustRedTTG added planned This behavior is intended / The Feature is planned reproduced The issue has been reproduced and a fix is on the way and removed bug Something isn't working needs testing The issue or feature needs to be tested. labels Jan 14, 2025
@JustRedTTG
Copy link
Collaborator

screenshot

Thanks for the feedback, Moss requires some modifications from rmscene, so in order to keep up with new updates to rmscene Moss now has a patching script to pull and modify rmscene automatically, this is already seeing success and is stable.

The only thing missing is preparing the necessary pens and colors and making sure they are consistent as possible.
You can expect this to come in 0.0.6.

@JustRedTTG
Copy link
Collaborator

@jantb You are welcome to make pull requests or test on the experimental branch!
All development changes take place there

@JustRedTTG JustRedTTG added the bug Something isn't working label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned This behavior is intended / The Feature is planned reproduced The issue has been reproduced and a fix is on the way
Projects
None yet
Development

No branches or pull requests

2 participants