-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rmlines does does not handle highlighters correctly #12
Comments
Which highlighter color are you drawing? And what is your tablet version? Moss doesn't have full support for newer versions but I am looking to support it, you can submit your rm file for testing too, we are looking for testers in the discord server too. |
Yellow and blue, both get color number 9 in the rm_lines; Version 3.17.0.62 on a reMarkable pro. The newest beta with shapes. |
Please share a PNG and the .rm file of the document and I'll add them in |
Here are the files and screenshots |
RmScene has some more code in the PenColor enum, but is seems a bit incomplete since they cant figure out the highlight color |
Thanks for the feedback, Moss requires some modifications from rmscene, so in order to keep up with new updates to rmscene Moss now has a patching script to pull and modify rmscene automatically, this is already seeing success and is stable. The only thing missing is preparing the necessary pens and colors and making sure they are consistent as possible. |
@jantb You are welcome to make pull requests or test on the experimental branch! |
Rmlines reads the pen color of the highlighter as value 9. the pen color enum only goes to number 8.
Create a notebook with a single highlight. Open the file on moss-desktop. Notice the highlight is missin from the note view. When placing a debug inside the code that parses the pen_color it shows the number 9. Then it tries to convert it to an enum, and fails.
It should record the penstroke with color.
Desktop:
The text was updated successfully, but these errors were encountered: