Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relisten doesn't go to show for link if the app isn't already open #131

Closed
farktronix opened this issue Sep 6, 2018 · 2 comments
Closed

Comments

@farktronix
Copy link
Member

A report from user @carl on Discord:

When I share a link to a recording from within an the app to someone else via iMessage or SMS, if the recipient does not have the app open before they tap the link, the app will open but it will not go to the recording. If the recipient has the app open already, when they tap the link it will bring the app to the foreground and load the recording

I can reproduce this, so it should be easy to debug.

@alecgorge
Copy link
Member

@farktronix in didFinishLaunchingWithOptions: one of the options is UIApplication.LaunchOptionsKey.url
which contains the URL that the app was trying to open
so we just need to hand that off so that it actually gets parsed
probably need to implement application:openURL:options as well

@farktronix
Copy link
Member Author

I have a fix for this on the UniversalLinks branch, but there's no way to test this. 😠

On both my iPhone and the simulator I just get taken to Safari when I tap on a universal link. When I go to relisten.net on my phone and I have a development version of the app installed the app banner wants me to go to the store to download the app.

We could try just checking this in blind, or we can keep trying to figure out why the system doesn't like our links. One idea is RelistenNet/relisten-web#37, and another is that the json file needs to be signed even though it's served over https and that shouldn't be necessary any more.

alecgorge added a commit that referenced this issue Sep 13, 2018
Relisten doesn't go to show for link if the app isn't already open #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants