Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of the "mainProject" file #2

Open
JasonHK opened this issue Aug 2, 2020 · 1 comment
Open

Location of the "mainProject" file #2

JasonHK opened this issue Aug 2, 2020 · 1 comment

Comments

@JasonHK
Copy link
Contributor

JasonHK commented Aug 2, 2020

Shouldn't be better this file stored in the parent project instead of one level of folders up? I think it may cause problems in some cases.

val coreProjectFile = project.file("../mainProject")

@Johni0702
Copy link
Member

Yeah, it could cause problems if you don't have all your versions in the same folder (one plausible example would be someone wanting to support Fabric and Forge with a structure like fabric/1.15.2/, fabric/1.16.2/, forge/1.15.2/, forge/1.16.2/).
Merely having it be relative to the parent project would then introduce a different assumption though: the RM places the file relative to the root project at versions/mainProject, while the above example would likely prefer it to be at ./mainProject.

Ideally the location of that file should just be configurable via the parent project's RootPreprocessExtension (defaulting to the current behavior of placing it one folder up from one of the sub-projects).

Deftu added a commit to Deftu/ReplayMod-Preprocessor that referenced this issue Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants