Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API_GetGameLeaderboards returns incorrect total number of leaderboards for some games #3090

Open
tepiloxtl opened this issue Jan 22, 2025 · 2 comments
Labels
area/api-web Web API kind/bug Something isn't working php Pull requests that update Php code

Comments

@tepiloxtl
Copy link

Describe the bug
I've noticed it on games with no leaderboards. Some games will return {"Count":0,"Total":1,"Results":[]}, other returns {"Count":0,"Total":0,"Results":[]}

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://retroachievements.org/API/API_GetGameLeaderboards.php?i=10434&y=...' for leaderboards for Crash Bandicoot

Expected behavior
Total value should be 0

Desktop (please complete the following information):

  • OS: Windows, Linux
  • Browser: Firefox, Python requests
  • Version: 134.0.1, 2.32.3

Additional context
This may also apply to titles with leaderboards, where total number is inflated by 1, I have not tried to test this yet, will update later

@tepiloxtl
Copy link
Author

tepiloxtl commented Jan 22, 2025

I've been told about hidden leaderboards, and that Crash Bandicoot have one. So the question should be, if hidden leaderboards are not being returned, should they still be counted in total count

@wescopeland wescopeland added kind/bug Something isn't working area/api-web Web API php Pull requests that update Php code labels Jan 22, 2025
@wescopeland
Copy link
Member

Hidden leaderboards should not be included in total.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-web Web API kind/bug Something isn't working php Pull requests that update Php code
Projects
None yet
Development

No branches or pull requests

2 participants