Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables are not localized correctly #4770

Closed
2 of 6 tasks
futuretap opened this issue Feb 6, 2025 · 4 comments
Closed
2 of 6 tasks

Variables are not localized correctly #4770

futuretap opened this issue Feb 6, 2025 · 4 comments
Labels

Comments

@futuretap
Copy link

Describe the bug
When using the German localization, standard (static) texts are localized but all variable content is not localized but just empty.

  1. Environment
    1. Platform: iOS
    2. SDK version: 5.16.1
    3. StoreKit version:
      • StoreKit 1 (default on versions <5.0.0. Can be enabled in versions >=5.0.0 with .with(storeKitVersion: .storeKit1))
      • StoreKit 2 (default on versions >=5.0.0)
    4. OS version: 18.2
    5. Xcode version: 16.2
    6. Device and/or simulator:
      • Device
      • [x ] Simulator
    7. Environment:
      • [ x] Sandbox
      • TestFlight
      • Production
    8. How widespread is the issue. Percentage of devices affected: 100% reproducible
  2. Debug logs that reproduce the issue. Complete logs with Purchases.logLevel = .verbose will help us debug this issue.
Logs here
  1. Steps to reproduce, with a description of expected vs. actual behavior

Create a Paywall with variable content that is localized in German.
The variable content is not localized but just empty.

  1. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)
    This seems to be a bug in the SDK. I can fix the issue by changing one line, UIConfigProvider.swift:53:

guard let localizations = self.uiConfig.localizations[locale.identifier] ?? self.uiConfig.localizations[locale.languageCode ?? locale.identifier] else {

The workaround is dirty and you should fix this properly.

  1. Additional context
@futuretap futuretap added the bug label Feb 6, 2025
@RCGitBot
Copy link
Contributor

RCGitBot commented Feb 6, 2025

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@nyeu
Copy link
Contributor

nyeu commented Feb 10, 2025

Hi @futuretap,
We've made a fix for this issue and it's going to be available in the next SDK version. I'll keep this issue opened until we verify this is fixed for your case.
Best,

@nyeu
Copy link
Contributor

nyeu commented Feb 28, 2025

Hi @futuretap,
This should be fixed in the latest version. Let me know if it works on your end so we can close the ticket.

@futuretap
Copy link
Author

Yep, looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants