Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

pep8 nudeges #105

Open
1 task done
delgadom opened this issue Sep 27, 2019 · 4 comments
Open
1 task done

pep8 nudeges #105

delgadom opened this issue Sep 27, 2019 · 4 comments

Comments

@delgadom
Copy link
Member

delgadom commented Sep 27, 2019

anything we can do on the image side to push users in a good coding style direction?

  • ruler in notebooks/text editor

anything else?

@bolliger32

@bolliger32
Copy link
Member

Include a best-practices markdown file in the home directory, including telling people how to use flake8?

@brews
Copy link
Member

brews commented Oct 22, 2019

Ian pointed me to this issue. This might be a solution for yall https://github.com/dfm/black_nbconvert?

@bolliger32
Copy link
Member

this is not pep8 related, but could be useful for us...

https://medium.com/@kevinkreuzer/the-way-to-fully-automated-releases-in-open-source-projects-44c015f38fd6

@brews
Copy link
Member

brews commented Nov 4, 2019

I actually think we're pretty close to fully automated releases on python packages, unless you're looking for something specific. The only parts that aren't automated, 1) developer still needs to tag, push commits, 2) conda packages arn't 100% automated in a fool proof way.

As for pep8 stuff. I got to play with black and black_nbconvert last week. I think we could implement either as an optional part of your jupyterhub environments for users, or as a more automated check/autoformat for actual packaged code. I wouldn't recommend it unless you have decent automated unit tests, as I was able to trick black into breaking code. It's very good but it's not bomb proof (and I don't think we should think of any auto-styler as bomb-proof).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants