-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock interface & Context argument #803
Comments
agcom
added a commit
to agcom/machinery
that referenced
this issue
Mar 28, 2024
agcom
added a commit
to agcom/machinery
that referenced
this issue
Mar 28, 2024
Related to RichardKnop#803; see RichardKnop#803.
agcom
added a commit
to agcom/machinery
that referenced
this issue
Mar 28, 2024
Related to RichardKnop#793; see RichardKnop#803.
agcom
added a commit
to agcom/machinery
that referenced
this issue
Mar 28, 2024
Related to RichardKnop#793; see RichardKnop#803.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Redis-lock methods do not receive a context argument; the merged PR #652 did a trick of passing the Redis client's context to its own methods' calls, which I strongly doubt its impact. Moving on, go-redis was updated to v9 on #793; the new client removed access to its maybe internal context; therefore, the below line was commented.
machinery/v1/locks/redis/redis.go
Line 68 in 0c29c70
I guess that the lock interface methods should receive a context argument to possibly cancel the lock operation, specially in case the Redis calls take too much time; what are your thoughts?
The text was updated successfully, but these errors were encountered: