Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also alias node:* imports #19

Open
fregante opened this issue Sep 7, 2021 · 2 comments
Open

Also alias node:* imports #19

fregante opened this issue Sep 7, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@fregante
Copy link

fregante commented Sep 7, 2021

When this webpack issue is resolved: webpack/webpack#14166

According to this comment, the path: scheme is only supported by webpack if the target is node:

webpack/webpack#12693 (comment)

And I don’t think there's any node: scheme handler either, which makes this plugin possibly the "right place" to fix this.

@Richienb
Copy link
Owner

Richienb commented Nov 20, 2024

We should add a node: scheme handler within this plugin, and then remove it when Webpack supports it by default.
I think it would rewrite all of the node:* imports to *, for every import that this plugin is polyfilling.
Alternatively, we could make it a separate plugin, though I'm not sure whether that would mean we use it here or ask the user to use it elsewhere.

@Richienb
Copy link
Owner

@Richienb Richienb pinned this issue Dec 3, 2024
@Richienb Richienb added enhancement New feature or request help wanted Extra attention is needed labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants