Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Biome Tags in Deposit "biomes" Field #210

Open
vertexcubed opened this issue Aug 13, 2023 · 1 comment
Open

Multiple Biome Tags in Deposit "biomes" Field #210

vertexcubed opened this issue Aug 13, 2023 · 1 comment
Assignees
Labels
feature request New feature or request undergoing development Undergoing Development

Comments

@vertexcubed
Copy link

Describe the feature you'd like

when making a deposit, you're only allowed a single biome tag in the biomes field, which is quite annoying. It would be nice if you could put multiple.

Examples:

{
    "type": "emendatusenigmatica:vanilla_deposit",
    "dimension": "minecraft:overworld",
    "registryName": "my_deposit",
    //currently not valid, it would be nice if it was
    "biomes": ["#minecraft:is_ocean", "#minecraft:is_river"],
    "config": {...}
}

{
    //using biome tags and biome ids together would also be very useful
    "biomes": ["#minecraft:is_ocean", "minecraft:dark_forest"] 
}

Describe alternatives you've considered

The only real alternative right now is to make a separate biome tag that contains every tag / biome you want to use, which is not ideal.

Additional context

No response

@vertexcubed vertexcubed added feature request New feature or request to be reviewed requires additional analysis labels Aug 13, 2023
@Ridanisaurus
Copy link
Owner

As far as I remember this is something I looked into while working on the refactor and it was not possible due to how 1.19 handles world generation. It is an either/or situation.
I'll look into it again for the 1.20 version (because OF COURSE Mojang re did world generation .. again) and will see how it goes.

@Ridanisaurus Ridanisaurus added undergoing development Undergoing Development and removed to be reviewed requires additional analysis labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request undergoing development Undergoing Development
Projects
None yet
Development

No branches or pull requests

2 participants