Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithread ? #218

Closed
jenskastensson opened this issue Dec 23, 2022 · 4 comments
Closed

Multithread ? #218

jenskastensson opened this issue Dec 23, 2022 · 4 comments
Labels
stale wontfix This will not be worked on

Comments

@jenskastensson
Copy link

Hi and thanks for a amazing work !
I tested the ladspa filter on a Allwinner H3 (ARM Cortex-A7 Quad-Core 1.296 GHz) , it was easy to install; great work
The filter seems to be single-threaded, a single core seems not be enough to process. Would it be possible to involve the other cores ?

2022-12-22T16:33:37.579Z | WARN |  deep_filter_ladspa | DF 7b7326a9e80d | Underrun detected (RTF: 2.39). Processing too slow!
overrun!!! (at least 277.761 ms long)
2022-12-22T16:33:38.903Z | WARN |  deep_filter_ladspa | DF 3bfb6693797b | Underrun detected (RTF: 2.48). Processing too slow!
overrun!!! (at least 312.537 ms long)
2022-12-22T16:33:40.179Z | WARN |  deep_filter_ladspa | DF 9f61b96d4beb | Underrun detected (RTF: 2.36). Processing too slow!
overrun!!! (at least 266.241 ms long)
2022-12-22T16:33:41.476Z | WARN |  deep_filter_ladspa | DF 54a1822b409f | Underrun detected (RTF: 2.41). Processing too slow!
overrun!!! (at least 284.917 ms long)
@Rikorose
Copy link
Owner

Not with the current DNN framework. One option could be #210, but this will only bring approx 30% improvement.

@Rikorose Rikorose added the wontfix This will not be worked on label Dec 23, 2022
@jenskastensson
Copy link
Author

jenskastensson commented Jan 3, 2023

Thank you @Rikorose for the reply, let's hope the 30% improvement is enough. Having tested the stand alone application on a different device I must say the results are really amazing, kudos to you and the team !

Question: would it make any difference (in regards of CPU), if the required performance of the filter is reduced / less ambitious ?
(I know it is a long shot but wanted to ask anyway)

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Apr 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
@UnlimitedCookies
Copy link

:(
Multi-threading could be a real improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants