Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dateStrings option #154

Open
mnpenner opened this issue May 12, 2024 · 3 comments
Open

Support dateStrings option #154

mnpenner opened this issue May 12, 2024 · 3 comments
Labels
in progress We're working on it

Comments

@mnpenner
Copy link

mnpenner commented May 12, 2024

Kysley MysqlDialect / createPool from mysql2 has a dateStrings option which returns MySQL TIMESTAMPs, DATETIMEs and DATEs as strings instead of JS Date dates.

Can we get an option for kysley-codegen to output string instead of Date so that the type definitions match what's returned?

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@RobinBlomberg RobinBlomberg added in progress We're working on it and removed in progress We're working on it labels Oct 17, 2024
@RobinBlomberg RobinBlomberg added the in progress We're working on it label Nov 8, 2024
@rowan-gud
Copy link

rowan-gud commented Dec 18, 2024

@RobinBlomberg any update on this? I feel like this could be another parser type like dateParser. I would love for this to be an option for postgres TIMESTAMP and TIMESTAMPTZ types too. That would mean adding options to the MySQL Adapter though

EDIT: Also happy to submit a PR for this

@bherila
Copy link

bherila commented Jan 6, 2025

I would love this! I am happy to help test it or whatever is helpful.

@bherila
Copy link

bherila commented Jan 6, 2025

PR ready for review #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress We're working on it
Projects
None yet
Development

No branches or pull requests

4 participants