Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation after changing 'command Listen Port' #128

Open
kianbehzad opened this issue Dec 22, 2020 · 1 comment
Open

Segmentation after changing 'command Listen Port' #128

kianbehzad opened this issue Dec 22, 2020 · 1 comment
Labels

Comments

@kianbehzad
Copy link

kianbehzad commented Dec 22, 2020

Describe the bug
The initial state of the commandSocket works fine. However, after changing the command Listen Port grSim crashes after receiving new commands. (this issue happens most frequently in macOS )

To Reproduce
Steps to reproduce the behavior:
most frequently happens in macOS, rarely in ubuntu due to its memory management policy

  1. open both grSim and the client
  2. change command Listen Port from grSim
  3. connect to the new port from the client and send new commands.
  4. grSim will be terminated

Expected behavior
receive the commands from the new port and apply them.

Desktop

  • OS: macOS
  • Version 10.15

My opinion to fix the issue
add the following line in mainwindow.cpp -> reconnectCommandSocket function (before connecting signal and slot)

glwidget->ssl->commandSocket = commandSocket;
@kianbehzad kianbehzad added the bug label Dec 22, 2020
@g3force
Copy link
Member

g3force commented Feb 5, 2021

I've run into the same or similar issue and fixed it here: 06edd4f

Can you verify if this solves your issue as well? You can test it on the feature/simulator-protocol branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants