Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[colcon] Upstream test isolation to colcon test #313

Closed
adityapande-1995 opened this issue Nov 1, 2023 · 4 comments
Closed

[colcon] Upstream test isolation to colcon test #313

adityapande-1995 opened this issue Nov 1, 2023 · 4 comments
Assignees

Comments

@adityapande-1995
Copy link
Collaborator

It would be nice to upstream #277 to colcon, such that one can run tests in parallel with isolation.

@adityapande-1995 adityapande-1995 self-assigned this Nov 1, 2023
@adityapande-1995
Copy link
Collaborator Author

I opened a draft repo here : https://github.com/adityapande-1995/colcon-test-isolated/tree/main, which adds a new test step action for python. Getting the "isolate" executable is tricky here, since colcon tries not to mix python and C++ code. Essentially we're creating a command line tool that is invoked using the test step action.

One option would be to write the test isolation stuff in pure python.

@adityapande-1995
Copy link
Collaborator Author

After a brief discussion with the ros team, looks like mixing C++ and python code would be tricky if mixed in the same colcon repo. I'll try to rewrite the isolation script in pure python, and use that in colcon using shell extensions, rather than using the python test step action, which would have to be replicated to bne used with cmake. The shell approach makes it more generic.

@adityapande-1995
Copy link
Collaborator Author

Made a pip installable pure python package to be used as a command line tool :
https://github.com/adityapande-1995/isolate-ros

@adityapande-1995
Copy link
Collaborator Author

Closing this as we have a new package released into rolling here : ros/rosdistro#39743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant