Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoS - API and implementation for Liveliness and Deadline event callbacks #492

Open
minggangw opened this issue May 27, 2019 · 3 comments
Open

Comments

@minggangw
Copy link
Member

No description provided.

@minggangw
Copy link
Member Author

Continued from #498

for this thing I need to add one more paramter in the methods which is used for creating Publisher/Subsciber, so I m asking if need to embed this new parameter inside options object or add just add a new paramter field.
What guidelines is followed I dont know

We suggest aligning with interfaces of rclpy, there is no guideline for designing an interface

what is the use of timerCallback(),I have seen that at the end this function calls rcl_timer.c but cant understand what is its role

timer.callback() will trigger the callback function passed when creating this timer

@caelinsutch
Copy link

Is this taken?

@minggangw
Copy link
Member Author

No, it' not. Please feel free to take it if you are interested in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants