Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_multi_subscriber test is flaky when unregistering topics #969

Open
sea-bass opened this issue Oct 13, 2024 · 0 comments
Open

test_multi_subscriber test is flaky when unregistering topics #969

sea-bass opened this issue Oct 13, 2024 · 0 comments
Labels

Comments

@sea-bass
Copy link
Contributor

Description

  • Library Version: Latest version humble and ros2 branches
  • ROS Version: Humble and (sometimes) Jazzy?
  • Platform / OS: Ubuntu 22.04 / 24.04

Steps To Reproduce
The test_multi_subscriber.py test is flaky in weird ways... This is specifically when trying to unregister a topic with multiple subscribers.

  • On Humble, it fails consistently
  • On Jazzy, it seems flaky
  • Have not yet seen any failures on Iron or Rolling

The only related change that has gone in lately is #948, which could be the cause. But either way, nondeterminism is bad.

Expected Behavior
The test works deterministically.

Actual Behavior

              multi.unregister()
      >       self.assertFalse(is_topic_subscribed(self.node, topic))
      E       AssertionError: True is not false
      
      ../../src/c1dv9q94shc/rosbridge_suite/rosbridge_library/test/internal/subscribers/test_multi_subscriber.py:96: AssertionError
@sea-bass sea-bass added the bug label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant