Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown to add-members is not closing when clicked somewhere on modal #1306

Open
umangutkarsh opened this issue Jan 8, 2024 · 5 comments
Open
Assignees

Comments

@umangutkarsh
Copy link

Description:

Dropdown to add-members is not closing when clicked somewhere on modal or when clicked to close the dropdown, it is only closed when clicked outside.

Steps to reproduce:

  1. Start RocketChat server
  2. Go on home-page
  3. Click on Create Channel
  4. Fill details and try to add members.
  5. Now click somewhere on the modal or try to close the dropdown.

Expected behavior:

The dropdown should get closed when clicked on the modal somewhere or when clicked on the arrow-button to close it.

Actual behavior:

rc.webm

Server Setup Information:

  • Version of Rocket.Chat Server: v6.6.0-develop
  • Operating System: Windows 10 (running the server on gitpod)
  • NodeJS Version: v14.21.4
  • MongoDB Version: v6.0.3

Client Setup Information

  • Desktop App or Browser Version: Version 120.0.6099.199 (Official Build) (64-bit)
  • Operating System: Windows 10 (gitpod)
@umangutkarsh
Copy link
Author

Maintainers, should I start working on this one?

@hugocostadev
Copy link
Contributor

No need to ask for permission to fix the issue, feel free to work on it!
Just check if someone it's already raised a PR for that (should be linked in this issue).
Best of luck 🚀 👏


Questions? Help needed? Feature Requests?

@umangutkarsh
Copy link
Author

No need to ask for permission to fix the issue, feel free to work on it! Just check if someone it's already raised a PR for that (should be linked in this issue). Best of luck 🚀 👏

Questions? Help needed? Feature Requests?

@hugocostadev . Thanks for this. Please assign this issue to me, I'm working on it.

@umangutkarsh
Copy link
Author

Hi @hugocostadev . I have created a PR for this issue. If the size-change of dropdown is an issue, then I'll make changes.
Please let me know.
Thanks

@Spiral-Memory
Copy link

@umangutkarsh, first of all, I appreciate your effort in submitting the PR, and I understand that this issue has been assigned to you. However, I'd like to bring up the point in a considerate manner that it appears the problem is rooted in the fuselage design system itself. I conducted a direct test by running the storybook, and it seems that addressing the issue solely within the app may not resolve the underlying problem.

@hugocostadev, I've also raised a corresponding issue in the fuselage repository and submitted a PR for it. I kindly request to do a verification, and please inform me if my assessment is accurate. You can find the links here: Issue - #1261, PR - #1262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants