Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability derivatives may fluctuate slightly when a craft is reloaded in the editor. #3

Open
Rodhern opened this issue Feb 28, 2019 · 3 comments

Comments

@Rodhern
Copy link
Owner

Rodhern commented Feb 28, 2019

I noticed that even in my newest (experimental) commit I get small fluctuations in the calculated results. If for instance I load a craft and calculate the Cl and Cd, and then do it again, then I get little almost unnoticeable differences.

The differences I have seen so far (fingers crossed) are nowhere near the ones we experienced a while back with the parts cache issue (ferram4#177). Even so, it seems a bit mysterious to me.

@Rodhern
Copy link
Owner Author

Rodhern commented Mar 18, 2019

I think I can reduce the variations if I update this signature:
private double CriticalMachFactorForUnsmoothCrossSection(VoxelCrossSection[] crossSections, double finenessRatio, double sectionThickness)
to this:
private double CriticalMachFactorForUnsmoothCrossSection(VoxelCrossSection[] crossSections, int frontIndex, int backIndex, double finenessRatio, double sectionThickness)

It does not eliminate the fluctuations but they seem to become less pronounced in my example(s).

@Rodhern
Copy link
Owner Author

Rodhern commented May 24, 2019

If you still notice these fluctuations in the newest release, tagged v0.15.9.1_Rodhern_update_4, and particularly if you are able to tell under which circumstances it happens, please let me know.

Rodhern pushed a commit that referenced this issue Feb 22, 2020
@Rodhern
Copy link
Owner Author

Rodhern commented Feb 22, 2020

Notice: I have confused Github by merging a local dkavolis branch copy. The "dkavolis#3" issue that dkavolis reference in d9665fb is confused with "#3".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant