Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework docker container #25

Open
n3ph opened this issue Feb 14, 2021 · 1 comment
Open

Rework docker container #25

n3ph opened this issue Feb 14, 2021 · 1 comment

Comments

@n3ph
Copy link
Member

n3ph commented Feb 14, 2021

As @cfra already mentioned in #24 (comment) we need the docker container to actually enable the user developing juntagrico code.

Proposal 1:

Proposal 2:

@cfra
Copy link
Contributor

cfra commented Feb 15, 2021

Proposal 1:

This would allow for nice tracking of juntagrico branches. However, my experience with git submodules thus far has always been that they are cumbersome, annoying and should best be avoided.

Proposal 2:

It might be worthwhile to discuss with upstream if they would be interested to have a docker based development setup.

Right now, it seems they do their development using runserver and sqlite: juntagrico/juntagrico#365 (comment)

Proposal 3:

I don't have a good answer to all of this yet, but in my opinion, it would be useful for a development setup if code could be tested without having to rebuild images and recreate containers for every change.

I pushed a very rough draft of how this could look here: 7a659f2

But I am not 100% sure if this is indeed the way to go, or if other approaches would be better.

Thinking about this a bit more, I believe that directly mounting juntagrico to /home/app/web is not really the right approach:

Depending on our functional requirements, we will not only use the Juntagrico Django app, but also add other apps.

In this scenario juntagrico really is just a package that we are using.

If we want to perform development on the juntagrico package in this setup, then the proper way would probably be to install the juntagrico package in editable mode. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants